feat: Implement and configure GKE Image Streaming (GCFS) at the cluster level.#5387
Conversation
…er level. Currently toolkit only support it at nodepool, which means for each nodepool it needs to be manually enabled.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the process of enabling Google Container Filesystem (GCFS) for Image Streaming in GKE clusters. Previously requiring manual configuration for each node pool, this change introduces a single cluster-level toggle, simplifying management and ensuring consistent application of GCFS across the entire cluster. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for enabling GKE Image Streaming (GCFS) at the cluster level, which is a useful feature for simplifying configuration. The implementation is straightforward, adding a new enable_gcfs variable to the gke-cluster module and using it to configure node_pool_defaults. I have one minor suggestion regarding variable ordering for consistency. Additionally, this change highlights a limitation in the gke-node-pool module where it's not possible to explicitly disable GCFS for a specific node pool if it's enabled at the cluster level. This could be a consideration for a future enhancement to provide more granular control.
|
/gcbrun |
|
Running tests with babysit |
|
SUCCESS[2] PR-test-gke go/ghpc-cb/c24e6d6b-92de-4fa0-b2d3-f131ce4ad8d8 |
a190444
into
GoogleCloudPlatform:develop
…er level. (GoogleCloudPlatform#5387) Co-authored-by: Swarna Bharathi Mantena <swarnabm@google.com>
Currently toolkit only support it at nodepool, which means for each nodepool it needs to be manually enabled.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.