Skip to content

Enable JobSet and Nvidia Data Center monitoring by default#5384

Merged
SwarnaBharathiMantena merged 3 commits into
GoogleCloudPlatform:developfrom
SikaGrr:origin/monitoring_defaults
Mar 24, 2026
Merged

Enable JobSet and Nvidia Data Center monitoring by default#5384
SwarnaBharathiMantena merged 3 commits into
GoogleCloudPlatform:developfrom
SikaGrr:origin/monitoring_defaults

Conversation

@SikaGrr

@SikaGrr SikaGrr commented Mar 23, 2026 •
edited by Neelabh94
Loading

Copy link
Copy Markdown
Contributor

This PR changes monitoring defaults.

@SikaGrr SikaGrr requested review from a team and samskillman as code owners March 23, 2026 12:57
@gemini-code-assist

gemini-code-assist Bot commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the default configurations for GKE clusters to align with new internal requirements. It specifically enables NVIDIA Data Center GPU Manager (DCGM) monitoring and the JobSet component by default, enhancing the out-of-the-box monitoring and job management capabilities for users.

Highlights

  • Default Monitoring Enabled: The default value for enable_dcgm_monitoring has been changed from false to true, enabling NVIDIA Data Center GPU Manager (DCGM) metrics collection by default for GKE clusters.
  • JobSet Component Enabled: The JOBSET component has been added to the list of default_enabled_components, ensuring JobSet functionality is active by default in GKE clusters.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@github-actions github-actions Bot added the external PR from external contributor label Mar 23, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 23, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully updates the default monitoring components to include JOBSET and sets enable_dcgm_monitoring to true by default, aligning with the objective to enable JobSet and Nvidia Data Center monitoring. The README.md has also been updated to reflect the new default value for enable_dcgm_monitoring.

@SwarnaBharathiMantena SwarnaBharathiMantena added release-breaking-changes Prevents "smooth" re-deploy across versions release-module-improvements Added to release notes under the "Module Improvements" heading. labels Mar 23, 2026
SwarnaBharathiMantena
SwarnaBharathiMantena approved these changes Mar 23, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SwarnaBharathiMantena

SwarnaBharathiMantena commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

/gcbrun

@SwarnaBharathiMantena

SwarnaBharathiMantena commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Running tests

Neelabh94
Neelabh94 approved these changes Mar 23, 2026
View reviewed changes

@Neelabh94 Neelabh94 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SwarnaBharathiMantena SwarnaBharathiMantena enabled auto-merge (squash) March 24, 2026 12:16
@SwarnaBharathiMantena SwarnaBharathiMantena merged commit a2a9e76 into GoogleCloudPlatform:develop Mar 24, 2026
28 of 75 checks passed
FIoannides pushed a commit to FIoannides/cluster-toolkit that referenced this pull request Mar 27, 2026
@SikaGrr @FIoannides
Enable JobSet and Nvidia Data Center monitoring by default (GoogleClo…
4a8aca1 
…udPlatform#5384)

Co-authored-by: Swarna Bharathi Mantena <swarnabm@google.com> and Neelabh94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neelabh94 Neelabh94 Neelabh94 approved these changes

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

external PR from external contributor release-breaking-changes Prevents "smooth" re-deploy across versions release-module-improvements Added to release notes under the "Module Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SikaGrr @SwarnaBharathiMantena @Neelabh94