Skip to content

Update fielstore tier default#5379

Merged
saara-tyagi27 merged 4 commits into
GoogleCloudPlatform:developfrom
saara-tyagi27:update-tier-default
Apr 2, 2026
Merged

Update fielstore tier default#5379
saara-tyagi27 merged 4 commits into
GoogleCloudPlatform:developfrom
saara-tyagi27:update-tier-default

Conversation

@saara-tyagi27

@saara-tyagi27 saara-tyagi27 commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Update filestore tier default to BASIC SSD as it provides a much better baseline performance/cost trade-off for general-purpose shared home directories.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@saara-tyagi27 saara-tyagi27 marked this pull request as ready for review March 23, 2026 04:51
@saara-tyagi27 saara-tyagi27 requested review from a team and samskillman as code owners March 23, 2026 04:51
@gemini-code-assist

gemini-code-assist Bot commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the default Filestore tier to BASIC_SSD, aiming to improve the performance/cost trade-off for shared home directories. This change ensures a better baseline performance for general-purpose usage.

Highlights

  • Filestore Tier Default: The default Filestore tier has been updated from BASIC_HDD to BASIC_SSD.
  • Performance Improvement: BASIC_SSD provides better baseline performance and cost-effectiveness for general-purpose shared home directories.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 23, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default filestore tier to BASIC_SSD. The module's README.md needs to be updated to reflect this change. I've left a specific comment on the required documentation updates.

Comment thread modules/file-system/filestore/variables.tf
@saara-tyagi27 saara-tyagi27 added documentation Improvements or additions to documentation release-improvements Added to release notes under the "Improvements" heading. labels Mar 23, 2026
shubpal07
shubpal07 reviewed Mar 24, 2026
View reviewed changes
Comment thread modules/file-system/filestore/variables.tf
@shubpal07 shubpal07 self-requested a review March 26, 2026 07:17
shubpal07
shubpal07 approved these changes Mar 26, 2026
View reviewed changes

@shubpal07 shubpal07 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please run relevant filestore tests before merging.

@saara-tyagi27

saara-tyagi27 commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

Successfully ran the tests that implicitly used filestore_tier from default settings.

@saara-tyagi27 saara-tyagi27 merged commit e24b55e into GoogleCloudPlatform:develop Apr 2, 2026
27 of 68 checks passed
simrankaurb pushed a commit to simrankaurb/cluster-toolkit that referenced this pull request Apr 7, 2026
@saara-tyagi27 @simrankaurb
Update fielstore tier default (GoogleCloudPlatform#5379)
5526f63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shubpal07 shubpal07 shubpal07 approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saara-tyagi27 @shubpal07