Skip to content

Merge V1.84.0 into Develop#5349

Merged
siddhartha-quad merged 3 commits into
developfrom
main
Mar 13, 2026
Merged

Merge V1.84.0 into Develop#5349
siddhartha-quad merged 3 commits into
developfrom
main

Conversation

@siddhartha-quad

@siddhartha-quad siddhartha-quad commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Merge V1.84.0 into Develop

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@siddhartha-quad siddhartha-quad added the release-chore To not include into release notes label Mar 12, 2026
@siddhartha-quad siddhartha-quad requested review from a team and samskillman as code owners March 12, 2026 11:33
@github-actions github-actions Bot added the external PR from external contributor label Mar 12, 2026
@gemini-code-assist

gemini-code-assist Bot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on a version bump for the HPC Toolkit. It updates the core toolkit version and ensures that all relevant Terraform modules, both community and core, are aligned with the new v1.84.0 release. This change is a standard maintenance task to reflect the latest development cycle.

Highlights

  • Version Update: The HPC Toolkit version has been updated from v1.83.0 to v1.84.0.
  • Module Version Alignment: All affected Terraform modules across both community/modules and modules directories have had their module_name metadata updated to reflect the new v1.84.0 version.
Changelog
  • cmd/root.go
    • Updated the toolkit version string from v1.83.0 to v1.84.0.
  • community/modules/compute/gke-nodeset/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • community/modules/compute/gke-partition/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • community/modules/compute/htcondor-execute-point/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • community/modules/compute/mig/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • community/modules/compute/schedmd-slurm-gcp-v6-nodeset-dynamic/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • community/modules/compute/schedmd-slurm-gcp-v6-nodeset-tpu/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • community/modules/compute/schedmd-slurm-gcp-v6-nodeset/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • community/modules/compute/schedmd-slurm-gcp-v6-partition/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • community/modules/database/slurm-cloudsql-federation/versions.tf
    • Updated the module version metadata for both google and google-beta providers from v1.83.0 to v1.84.0.
  • community/modules/file-system/nfs-server/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • community/modules/files/fsi-montecarlo-on-batch/versions.tf
    • Updated the module version metadata for both google and google-beta providers from v1.83.0 to v1.84.0.
  • community/modules/internal/slurm-gcp/login/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • community/modules/project/service-enablement/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • community/modules/pubsub/bigquery-sub/versions.tf
    • Updated the module version metadata for both google and google-beta providers from v1.83.0 to v1.84.0.
  • community/modules/pubsub/topic/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • community/modules/scheduler/htcondor-access-point/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • community/modules/scheduler/htcondor-central-manager/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • community/modules/scheduler/htcondor-pool-secrets/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • community/modules/scheduler/schedmd-slurm-gcp-v6-controller/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • community/modules/scheduler/schedmd-slurm-gcp-v6-login/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • community/modules/scripts/wait-for-startup/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • community/modules/scripts/windows-startup-script/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • modules/compute/gke-node-pool/versions.tf
    • Updated the module version metadata for both google and google-beta providers from v1.83.0 to v1.84.0.
  • modules/compute/resource-policy/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • modules/compute/vm-instance/versions.tf
    • Updated the module version metadata for both google and google-beta providers from v1.83.0 to v1.84.0.
  • modules/file-system/cloud-storage-bucket/versions.tf
    • Updated the module version metadata for both google and google-beta providers from v1.83.0 to v1.84.0.
  • modules/file-system/filestore/versions.tf
    • Updated the module version metadata for both google and google-beta providers from v1.83.0 to v1.84.0.
  • modules/file-system/gke-persistent-volume/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • modules/file-system/gke-storage/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • modules/file-system/managed-lustre/versions.tf
    • Updated the module version metadata for both google and google-beta providers from v1.83.0 to v1.84.0.
  • modules/file-system/netapp-storage-pool/versions.tf
    • Updated the module version metadata for both google and google-beta providers from v1.83.0 to v1.84.0.
  • modules/file-system/netapp-volume/versions.tf
    • Updated the module version metadata for both google and google-beta providers from v1.83.0 to v1.84.0.
  • modules/management/kubectl-apply/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • modules/monitoring/dashboard/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • modules/network/firewall-rules/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • modules/network/pre-existing-subnetwork/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • modules/network/pre-existing-vpc/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • modules/network/private-service-access/versions.tf
    • Updated the module version metadata for both google and google-beta providers from v1.83.0 to v1.84.0.
  • modules/scheduler/batch-login-node/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • modules/scheduler/gke-cluster/versions.tf
    • Updated the module version metadata for both google and google-beta providers from v1.83.0 to v1.84.0.
  • modules/scheduler/pre-existing-gke-cluster/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
  • modules/scripts/startup-script/versions.tf
    • Updated the module version metadata from v1.83.0 to v1.84.0.
Activity
  • The pull request description includes a standard submission checklist, indicating the author's intent to follow contribution guidelines, test changes, and maintain code quality.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 12, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request merges version 1.84.0 into the develop branch. The changes consist of updating the version number from v1.83.0 to v1.84.0 across various Go and Terraform files. The updates are consistent and appear correct for a version bump. I have not found any issues with these changes.

@siddhartha-quad siddhartha-quad merged commit d9d3773 into develop Mar 13, 2026
20 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LAVEEN LAVEEN LAVEEN approved these changes

@kvenkatachala333 kvenkatachala333 kvenkatachala333 approved these changes

@samskillman samskillman Awaiting requested review from samskillman

@kadupoornima kadupoornima Awaiting requested review from kadupoornima

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siddhartha-quad @LAVEEN @kvenkatachala333