Skip to content

Add robust destroy to integration test#5345

Merged
LAVEEN merged 2 commits into
GoogleCloudPlatform:developfrom
LAVEEN:robustdestroy
Mar 12, 2026
Merged

Add robust destroy to integration test#5345
LAVEEN merged 2 commits into
GoogleCloudPlatform:developfrom
LAVEEN:robustdestroy

Conversation

@LAVEEN

@LAVEEN LAVEEN commented Mar 12, 2026

Copy link
Copy Markdown
Collaborator

Adding Robust Destroy to Integration Tests

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@LAVEEN LAVEEN added the release-chore To not include into release notes label Mar 12, 2026
@gemini-code-assist

gemini-code-assist Bot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the stability of integration tests by implementing a "robust destroy" mechanism for resource cleanup. By adding the --robust flag to gcluster destroy commands across various test playbooks and build configurations, the changes ensure that test environments are reliably torn down, reducing the likelihood of orphaned resources and improving overall test reliability.

Highlights

  • Enhanced Resource Destruction: The gcluster destroy command in several integration tests has been updated to include the --robust flag, aiming to improve the reliability and resilience of resource cleanup after test execution.
Changelog
  • tools/cloud-build/daily-tests/ansible_playbooks/htcondor-integration-test.yml
    • Updated gcluster destroy commands to include the --robust flag.
  • tools/cloud-build/daily-tests/ansible_playbooks/multigroup-integration-test.yml
    • Updated gcluster destroy command to include the --robust flag.
  • tools/cloud-build/daily-tests/ansible_playbooks/tasks/rescue_gcluster_failure.yml
    • Updated gcluster destroy command to include the --robust flag.
  • tools/cloud-build/daily-tests/builds/e2e.yaml
    • Updated gcluster destroy command to include the --robust flag.
  • tools/cloud-build/daily-tests/builds/gcluster-dockerfile.yaml
    • Updated gcluster destroy command to include the --robust flag.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 12, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the --robust flag to gcluster destroy commands across various integration tests. This is a good step towards making the cleanup process in tests more resilient. No specific comments are provided based on the repository's review guidelines.

@LAVEEN LAVEEN marked this pull request as ready for review March 12, 2026 13:39
@LAVEEN LAVEEN requested review from a team and samskillman as code owners March 12, 2026 13:39
@LAVEEN LAVEEN merged commit f156981 into GoogleCloudPlatform:develop Mar 12, 2026
74 of 78 checks passed
@SwarnaBharathiMantena SwarnaBharathiMantena mentioned this pull request Mar 16, 2026
Closed
scaliby pushed a commit to scaliby/cluster-toolkit that referenced this pull request Mar 17, 2026
@LAVEEN @scaliby
Add robust destroy to integration test (GoogleCloudPlatform#5345)
000564a 
Co-authored-by: laveen <laveenekka@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AdarshK15 AdarshK15 AdarshK15 approved these changes

@kvenkatachala333 kvenkatachala333 kvenkatachala333 approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LAVEEN @AdarshK15 @kvenkatachala333