Skip to content

Revert "feat: full_quota_impl"#5344

Merged
Neelabh94 merged 1 commit into
developfrom
revert-5140-quota-clean
Mar 12, 2026
Merged

Revert "feat: full_quota_impl"#5344
Neelabh94 merged 1 commit into
developfrom
revert-5140-quota-clean

Conversation

@Neelabh94

@Neelabh94 Neelabh94 commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Reverts #5140

@gemini-code-assist

gemini-code-assist Bot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a full revert of the 'full_quota_impl' feature. The change systematically removes all components related to the quota validation, ensuring that the system no longer performs these checks during deployment. This impacts the core deployment logic, the validator framework, and associated testing and configuration scripts.

Highlights

  • Quota Validation Removal: The entire quota validation feature, including its implementation and tests, has been removed from the codebase.
  • Deployment Command Update: The deploy command no longer imports the validators package or executes the quota validation checks.
  • Validator Framework Changes: The general validator framework has been updated to remove references to the quota availability test and simplify error handling related to Google APIs.
  • Validation Script Adjustments: Configuration validation scripts have been modified to no longer skip or process the test_quota_availability validator, reflecting its removal.
Changelog
  • cmd/deploy.go
    • Removed import of hpc-toolkit/pkg/validators.
    • Removed the call to validators.Execute(bp).
  • pkg/validators/quota.go
    • Deleted the file containing the entire quota validation implementation.
  • pkg/validators/quota_test.go
    • Deleted the file containing the tests for the quota validation logic.
  • pkg/validators/validators.go
    • Removed import of google.golang.org/api/googleapi.
    • Removed testQuotaAvailabilityName from the implementations map.
    • Simplified handleClientError by removing Google API specific error handling.
  • tools/validate_configs/golden_copies/validate.sh
    • Removed test_quota_availability from the VALIDATORS_TO_SKIP list.
    • Removed a sed command that previously stripped quota validator entries from expanded blueprints.
  • tools/validate_configs/validate_configs.sh
    • Removed test_quota_availability from the VALIDATORS_TO_SKIP list.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@Neelabh94 Neelabh94 marked this pull request as ready for review March 12, 2026 08:00
@Neelabh94 Neelabh94 requested review from a team and samskillman as code owners March 12, 2026 08:00
@Neelabh94 Neelabh94 added the release-chore To not include into release notes label Mar 12, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 12, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively reverts the full_quota_impl feature, removing the quota validation logic, its associated tests, and all references within the validation system. The changes are well-aligned with the stated goal of reverting the previous implementation. A potential issue was identified in the handleClientError function where the removal of a nil error check could lead to a runtime panic, which has been retained as a high-severity comment.

Comment thread pkg/validators/validators.go
@Neelabh94 Neelabh94 enabled auto-merge (squash) March 12, 2026 08:02
@Neelabh94 Neelabh94 merged commit 123e8ad into develop Mar 12, 2026
14 of 79 checks passed
@Neelabh94 Neelabh94 deleted the revert-5140-quota-clean branch March 12, 2026 09:05
scaliby pushed a commit to scaliby/cluster-toolkit that referenced this pull request Mar 17, 2026
@Neelabh94 @scaliby
Revert "feat: full_quota_impl" (GoogleCloudPlatform#5344)
2a07da4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LAVEEN LAVEEN LAVEEN approved these changes

@saara-tyagi27 saara-tyagi27 saara-tyagi27 approved these changes

@kvenkatachala333 kvenkatachala333 kvenkatachala333 approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Neelabh94 @LAVEEN @saara-tyagi27 @kvenkatachala333