Skip to content

add ttl label to remaining ml and gke focused blueprints#5294

Merged
saara-tyagi27 merged 1 commit into
GoogleCloudPlatform:developfrom
saara-tyagi27:add-labels-ml-gke
Mar 11, 2026
Merged

add ttl label to remaining ml and gke focused blueprints#5294
saara-tyagi27 merged 1 commit into
GoogleCloudPlatform:developfrom
saara-tyagi27:add-labels-ml-gke

Conversation

@saara-tyagi27

@saara-tyagi27 saara-tyagi27 commented Feb 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Add Time-to-live lables to remaining ml and gke focused blueprints

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@saara-tyagi27 saara-tyagi27 added the release-chore To not include into release notes label Feb 26, 2026
@gemini-code-assist

gemini-code-assist Bot commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @saara-tyagi27, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances resource management within daily cloud build tests by applying Time-To-Live (TTL) labels to a comprehensive set of Machine Learning and Google Kubernetes Engine (GKE) focused blueprints. This change ensures that resources provisioned by these blueprints are automatically tagged for deletion after a specified duration, thereby preventing resource accumulation and optimizing cloud costs.

Highlights

  • Automated Resource Cleanup: The add_ttl_label.sh script execution was integrated into several Machine Learning (ML) focused blueprint build configurations to ensure automated resource cleanup.
  • GKE Blueprint Enhancements: The add_ttl_label.sh script execution was also added to Google Kubernetes Engine (GKE) focused blueprint build configurations, extending the automated cleanup to these resources.
Changelog
  • tools/cloud-build/daily-tests/builds/ml-a3-ultragpu-jbvms.yaml
    • Added a step to execute tools/add_ttl_label.sh for the blueprint.
  • tools/cloud-build/daily-tests/builds/ml-a3-ultragpu-onspot-slurm.yaml
    • Added a step to execute tools/add_ttl_label.sh for the blueprint.
  • tools/cloud-build/daily-tests/builds/ml-a3-ultragpu-slurm.yaml
    • Added a step to execute tools/add_ttl_label.sh for the blueprint.
  • tools/cloud-build/daily-tests/builds/ml-a4-highgpu-custom-blueprint-test.yaml
    • Added a step to execute tools/add_ttl_label.sh for the blueprint.
  • tools/cloud-build/daily-tests/builds/ml-a4-highgpu-slurm.yaml
    • Added a step to execute tools/add_ttl_label.sh for the blueprint.
  • tools/cloud-build/daily-tests/builds/ml-g4-onspot-slurm.yaml
    • Added a step to execute tools/add_ttl_label.sh for the blueprint.
  • tools/cloud-build/daily-tests/builds/ml-gke-e2e.yaml
    • Added a step to execute tools/add_ttl_label.sh for the blueprint.
  • tools/cloud-build/daily-tests/builds/ml-gke.yaml
    • Added a step to execute tools/add_ttl_label.sh for the blueprint.
  • tools/cloud-build/daily-tests/builds/ml-h4d-onspot-slurm.yaml
    • Added a step to execute tools/add_ttl_label.sh for the blueprint.
  • tools/cloud-build/daily-tests/builds/ml-slurm.yaml
    • Defined the BLUEPRINT variable to specify the blueprint path.
    • Added a step to execute tools/add_ttl_label.sh for the blueprint.
Activity
  • The pull request description includes a submission checklist, indicating initial preparation by the author.
  • No further human activity (comments, reviews, or explicit progress updates) has been recorded since the pull request was created.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 26, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a time-to-live label to several ML and GKE-focused blueprints used in daily tests. This is achieved by calling the add_ttl_label.sh script in the cloud build configuration files. The changes are consistent and correct across all files. I have one minor suggestion for the ml-slurm.yaml file to improve conciseness by removing a temporary variable. Additionally, the pull request description is a template and does not explain the purpose of the change or how it was tested, which is encouraged by the repository's contribution guidelines.

Comment thread tools/cloud-build/daily-tests/builds/ml-slurm.yaml
@saara-tyagi27

saara-tyagi27 commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

a4high test with reservation fails due to reservation issue, but it works for onspot, same changes have been made for this test, similarly the case for a3ultra reservation test.

@saara-tyagi27 saara-tyagi27 marked this pull request as ready for review March 10, 2026 07:21
@saara-tyagi27 saara-tyagi27 requested review from a team and samskillman as code owners March 10, 2026 07:21
@saara-tyagi27 saara-tyagi27 merged commit 1aa18a0 into GoogleCloudPlatform:develop Mar 11, 2026
23 of 77 checks passed
@saara-tyagi27 saara-tyagi27 deleted the add-labels-ml-gke branch March 11, 2026 05:04
scaliby pushed a commit to scaliby/cluster-toolkit that referenced this pull request Mar 17, 2026
@saara-tyagi27 @scaliby
add ttl label to remaining ml and gke focused blueprints (GoogleCloud…
4cf5b58 
…Platform#5294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LAVEEN LAVEEN LAVEEN approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saara-tyagi27 @LAVEEN