Update and pin terraform version to 1.12.2#5216
Merged
parulbajaj01 merged 1 commit intoFeb 10, 2026
Merged
Conversation
Contributor
Summary of ChangesHello @parulbajaj01, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on standardizing the Terraform version used within the cluster toolkit to 1.12.2. This ensures consistency across deployments and leverages potential bug fixes and features available in the specified Terraform version. The changes involve updating version constraints in Highlights
Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request consistently updates the required Terraform version to a pinned version of 1.12.2 across the entire repository. The changes are extensive but appear to be correctly and consistently applied, aligning with the goal of standardizing the Terraform version. The PR description clearly outlines the reasons for the upgrade and the steps taken, which is helpful.
I've added a few comments with suggestions to improve maintainability by centralizing the version definition, which should make future version bumps easier and less error-prone. All comments are valid and do not contradict any provided rules. Overall, this is a solid and necessary update for the toolkit.
arpit974
approved these changes
Feb 10, 2026
c79c151
into
GoogleCloudPlatform:develop
73 of 83 checks passed
kadupoornima
pushed a commit
to kadupoornima/cluster-toolkit
that referenced
this pull request
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Terraform version to 1.12.2
This change updates the cluster toolkit to use Terraform version 1.12.2 consistently.
Reasons for Upgrade:
Changes Made:
= 1.12.2in allversions.tfand few other files.Troubleshooting & Fixes:
During pre-commit checks, errors like "Could not retrieve the list of available versions for provider..." were encountered. This was due to existing
.terraform.lock.hclfiles locking provider versions that were not compatible with Terraform 1.12.2 or causing resolution conflicts.To resolve this, all
.terraform.lock.hclfiles within the Cluster Toolkit directory were removed using:find . -name ".terraform.lock.hcl" -deleteThis forces Terraform to re-resolve provider dependencies compatible with version 1.12.2 upon the next
terraform init, generating new lock files.Impact:
.terraform.lock.hclfiles will be generated byterraform initreflecting dependencies compatible with TF 1.12.2.Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.