Skip to content

Enable DWS Flex Provisioning For G4#5113

Merged
LAVEEN merged 2 commits intoGoogleCloudPlatform:developfrom
LAVEEN:g4flex
Jan 16, 2026
Merged

Enable DWS Flex Provisioning For G4#5113
LAVEEN merged 2 commits intoGoogleCloudPlatform:developfrom
LAVEEN:g4flex

Conversation

@LAVEEN
Copy link
Contributor

@LAVEEN LAVEEN commented Jan 16, 2026

Adding support for DWS Flex Provisioning for G4 Machines.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@LAVEEN LAVEEN requested review from a team and samskillman as code owners January 16, 2026 08:31
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 16, 2026

Summary of Changes

Hello @LAVEEN, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the HPC Toolkit by integrating support for DWS Flex Provisioning for G4 machine types. This feature provides users with increased flexibility in managing and allocating resources for high-performance computing and machine learning workloads on G4 instances, allowing for more dynamic and efficient resource utilization.

Highlights

  • DWS Flex Provisioning: Introduced support for DWS Flex Provisioning specifically for G4 machine types within the HPC Toolkit configuration.
  • New Configuration Variable: Added a new configuration variable, g4_dws_flex_enabled, to the examples/ml-slurm-g4.yaml file, allowing users to enable or disable DWS Flex Provisioning.
  • YAML Integration: Integrated the dws_flex provisioning model into the g4-standard-384 deployment group within the example YAML, controlled by the new g4_dws_flex_enabled variable.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@LAVEEN LAVEEN added release-improvements Added to release notes under the "Improvements" heading. release-key-new-features Added to release notes under the "Key New Features" heading. and removed release-improvements Added to release notes under the "Improvements" heading. labels Jan 16, 2026
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 16, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for DWS Flex Provisioning for G4 machines by introducing a new variable, g4_dws_flex_enabled, in the ml-slurm-g4.yaml example. The change correctly wires this new variable to the dws_flex setting in the g4_nodeset module. My feedback focuses on improving the clarity of the in-code documentation for the new variable to better guide users, in line with the project's style guide. The provided rules did not necessitate any modifications or removal of this comment.

sarthakag
sarthakag previously approved these changes Jan 16, 2026
View reviewed changes
@LAVEEN LAVEEN requested a review from sarthakag January 16, 2026 09:38
@LAVEEN LAVEEN enabled auto-merge (squash) January 16, 2026 09:39
@LAVEEN LAVEEN merged commit e10dafe into GoogleCloudPlatform:develop Jan 16, 2026
13 of 75 checks passed
kvenkatachala333 pushed a commit to kvenkatachala333/cluster-toolkit that referenced this pull request Jan 28, 2026
@LAVEEN @kvenkatachala333
Enable DWS Flex Provisioning For G4 (GoogleCloudPlatform#5113)
b190ad7 
Co-authored-by: laveen <laveenekka@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarthakag sarthakag sarthakag approved these changes

@samskillman samskillman Awaiting requested review from samskillman samskillman is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-key-new-features Added to release notes under the "Key New Features" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LAVEEN @sarthakag