Skip to content

Add gIB versions v1.1.1 and v1.1.0 for arm64#5090

Merged
Neelabh94 merged 1 commit intoGoogleCloudPlatform:developfrom
duncanspani:develop
Jan 13, 2026
Merged

Add gIB versions v1.1.1 and v1.1.0 for arm64#5090
Neelabh94 merged 1 commit intoGoogleCloudPlatform:developfrom
duncanspani:develop

Conversation

@duncanspani
Copy link
Contributor

@duncanspani duncanspani commented Jan 9, 2026 •
edited
Loading

Update kubectl-apply module to include latest gIB versions for ARM64

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@duncanspani duncanspani requested review from a team and samskillman as code owners January 9, 2026 22:58
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 9, 2026

Summary of Changes

Hello @duncanspani, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the kubectl-apply module's compatibility by extending support for additional gIB versions, specifically v1.1.1 and v1.1.0, when targeting arm64 architectures. This update ensures that users deploying on arm64 can utilize these newer gIB releases.

Highlights

  • gIB Version Support: Added v1.1.1 and v1.1.0 to the list of supported gIB versions for arm64 architecture within the kubectl-apply module.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 9, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for gIB versions v1.1.1 and v1.1.0 for the arm64 architecture. The change is correct, but I've suggested a small improvement for maintainability. To maintain consistency with the sorting order of gib_supported_versions_x86, I recommend sorting the new list of arm64 versions in ascending order as well. This will make the code easier to read and manage in the future.

sarthakag
sarthakag previously approved these changes Jan 12, 2026
View reviewed changes
Neelabh94
Neelabh94 previously approved these changes Jan 12, 2026
View reviewed changes
@Neelabh94
Copy link
Contributor

Neelabh94 commented Jan 12, 2026 •
edited
Loading

@duncanspani You can now merge the PR once all required tests pass. Please ensure you add a label before merging.
Also, please use the "Squash and Merge" option.

@Neelabh94
Copy link
Contributor

Neelabh94 commented Jan 12, 2026

/gcbrun

LAVEEN
LAVEEN previously approved these changes Jan 12, 2026
View reviewed changes
@duncanspani duncanspani dismissed stale reviews from LAVEEN, Neelabh94, and sarthakag via 89a3114 January 12, 2026 18:08
@Neelabh94 Neelabh94 added the release-version-updates Added to release notes under the "Version Updates" heading. label Jan 13, 2026
@Neelabh94
Copy link
Contributor

Neelabh94 commented Jan 13, 2026

/gcbrun

@Neelabh94 Neelabh94 enabled auto-merge (squash) January 13, 2026 05:32
@Neelabh94 Neelabh94 merged commit c751d56 into GoogleCloudPlatform:develop Jan 13, 2026
13 of 80 checks passed
kvenkatachala333 pushed a commit to kvenkatachala333/cluster-toolkit that referenced this pull request Jan 28, 2026
@duncanspani @kvenkatachala333
Add gIB versions v1.1.1 and v1.1.0 for arm64 (GoogleCloudPlatform#5090)
8f82319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarthakag sarthakag sarthakag approved these changes

@Neelabh94 Neelabh94 Neelabh94 approved these changes

@LAVEEN LAVEEN LAVEEN left review comments

@samskillman samskillman Awaiting requested review from samskillman samskillman is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version-updates Added to release notes under the "Version Updates" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@duncanspani @Neelabh94 @LAVEEN @sarthakag