Adding A4X Base Support to JBVM#4834
Merged
LAVEEN merged 6 commits intoGoogleCloudPlatform:developfrom Feb 9, 2026
Merged
Conversation
bytetwin
previously requested changes
Nov 11, 2025
bytetwin
reviewed
Nov 12, 2025
Member
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for the gpu_topology attribute in the placement_policy for VM instances. The changes are well-structured, including updates to the main Terraform logic, variable definitions, and documentation. I've provided a few suggestions to improve documentation accuracy, code style, and validation logic.
LAVEEN
pushed a commit
that referenced
this pull request
Dec 25, 2025
…d validation This commit updates the `placement_policy` variable in `modules/compute/vm-instance/variables.tf` to use a strict `object` type with optional fields, including the new `gpu_topology`. It also updates the validation block to correctly handle `null` values while preventing empty objects. The `main.tf` and `README.md` files are updated to reflect these changes.
kvenkatachala333
approved these changes
Feb 9, 2026
AdarshK15
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the gpu_topology attribute within the placement_policy for VM instances. This is necessary to support the upcoming A4x GPUs, which require a specific GPU topology to be defined for optimal performance.