added nvidia-repositories script#4553
Conversation
samskillman
left a comment
There was a problem hiding this comment.
Please run the PR tests on this. Also, that script is duplicating the same things lower in the blueprint, and likely opens the build up to upgrading packages at the wrong time (before they are held). Last, sudo is not needed here as they run as root.
samskillman
left a comment
There was a problem hiding this comment.
If we take this approach here, then let's do this across a3u and a4 both slurm and vms.
Please make sure to run all tests for A* slurm clusters.
sure. once i get it working for A3 ultra, i will change it for others as well. |
arpit974
left a comment
There was a problem hiding this comment.
changes looks good,
suggested changes seems to be taken care of.
will be taken care of in subsequent prs. |
will be taken care of in subsequent prs.
addressed feedback fix typo
15fde06 to
b7f4dac
Compare
7189867
into
GoogleCloudPlatform:develop
…/a3_ultra_slurm_nvidia_script added nvidia-repositories script
…/a3_ultra_slurm_nvidia_script added nvidia-repositories script
Submission Checklist
Added NVIDIA repositories following the new script in Guest OS accelerator images for A3 Ultra Slurm blueprint.
See below for example:
https://github.com/GoogleCloudPlatform/cluster-toolkit/pull/3615/files