Skip to content

Fix private address space for gke-a3-megagpu.yaml #4478

Merged
Neelabh94 merged 1 commit intoGoogleCloudPlatform:developfrom
omartin2010:patch-1
Jan 13, 2026
Merged

Fix private address space for gke-a3-megagpu.yaml #4478
Neelabh94 merged 1 commit intoGoogleCloudPlatform:developfrom
omartin2010:patch-1

Conversation

@omartin2010
Copy link
Contributor

this is private address space, not 192.169/16.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

this is private address space, not 192.169/16.
@omartin2010 omartin2010 requested review from a team and samskillman as code owners August 1, 2025 14:42
@omartin2010
Copy link
Contributor Author

@samskillman thoughts?

@samskillman samskillman changed the title Update gke-a3-megagpu.yaml Fix private address space for gke-a3-megagpu.yaml Sep 4, 2025
@samskillman samskillman added release-bugfix Added to release notes under the "Bug fixes" heading. release-breaking-changes Prevents "smooth" re-deploy across versions labels Sep 4, 2025
@samskillman
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@bytetwin bytetwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Ran the gpu test and its green

[PR-test-gke-a3-megagpu (hpc-toolkit-dev)](https://github.com/GoogleCloudPlatform/cluster-toolkit/pull/4478/checks?check_run_id=49640506940)Successful in 4755m — Summary

@Priya-Quad
Copy link
Contributor

@omartin2010 Please take some action on this PR, since it is open from very long.

@omartin2010
Copy link
Contributor Author

Not sure what action I need to take here? I don't approve anything here...

@bytetwin
Copy link
Collaborator

@samskillman Need additional lgtm as its community contribution.

@samskillman
Copy link
Collaborator

/gcbrun

@cboneti cboneti enabled auto-merge September 29, 2025 16:12
@samskillman
Copy link
Collaborator

/gcbrun(ac44667)

@Neelabh94
Copy link
Contributor

/gcbrun

@Neelabh94 Neelabh94 marked this pull request as draft January 13, 2026 06:48
auto-merge was automatically disabled January 13, 2026 06:48

Pull request was converted to draft

@Neelabh94 Neelabh94 marked this pull request as ready for review January 13, 2026 06:48
@Neelabh94 Neelabh94 enabled auto-merge (squash) January 13, 2026 06:48
@Neelabh94 Neelabh94 disabled auto-merge January 13, 2026 06:49
@Neelabh94 Neelabh94 closed this Jan 13, 2026
@Neelabh94 Neelabh94 reopened this Jan 13, 2026
@Neelabh94 Neelabh94 enabled auto-merge (squash) January 13, 2026 07:01
@Neelabh94
Copy link
Contributor

/gcbrun

@Neelabh94 Neelabh94 merged commit ffcf6dd into GoogleCloudPlatform:develop Jan 13, 2026
16 of 88 checks passed
kvenkatachala333 pushed a commit to kvenkatachala333/cluster-toolkit that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-breaking-changes Prevents "smooth" re-deploy across versions release-bugfix Added to release notes under the "Bug fixes" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants