chore/allow hyphens in partition_name and slurm_cluster_name, increase max length to 20 for slurm_cluster_name#4316
Merged
mufaqam-gcl merged 2 commits intoGoogleCloudPlatform:developfrom Jan 30, 2026
Conversation
5fed3bb to
3e9dc21
Compare
fbitoo-aneo
approved these changes
Aug 5, 2025
3e9dc21 to
3a929d8
Compare
Contributor
|
@rbekhtaoui Please take some action on this PR, since it is open from very long |
3a929d8 to
229f09b
Compare
…length to 20 for slurm_cluster_name
229f09b to
c38d0ea
Compare
Member
|
hi @rbekhtaoui, is this ready for review? |
Contributor
Author
Hello, yes |
faa1c40 to
b5d099c
Compare
sarthakag
approved these changes
Jan 30, 2026
Neelabh94
approved these changes
Jan 30, 2026
Contributor
Neelabh94
left a comment
There was a problem hiding this comment.
Thanks for the contribution
Contributor
|
/gcbrun |
90a9c1c
into
GoogleCloudPlatform:develop
12 of 78 checks passed
AdarshK15
pushed a commit
to AdarshK15/cluster-toolkit
that referenced
this pull request
Jan 31, 2026
…e max length to 20 for slurm_cluster_name (GoogleCloudPlatform#4316)
AdarshK15
pushed a commit
to AdarshK15/cluster-toolkit
that referenced
this pull request
Feb 5, 2026
…e max length to 20 for slurm_cluster_name (GoogleCloudPlatform#4316)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our setup, we have a Slurm cluster name that exceeds 9 characters and includes hyphens (-).
Similarly, some of our partition names also contain hyphens.
These naming patterns were not passing the existing validation rules in the Terraform module.
Changes made: