Skip to content

Improve Slurm GPU testing#4146

Merged
tpdownes merged 1 commit into
GoogleCloudPlatform:developfrom
tpdownes:smarter_enroot_test
May 20, 2025
Merged

Improve Slurm GPU testing#4146
tpdownes merged 1 commit into
GoogleCloudPlatform:developfrom
tpdownes:smarter_enroot_test

Conversation

@tpdownes

@tpdownes tpdownes commented May 19, 2025

Copy link
Copy Markdown
Contributor

This PR adds a test for Slurm on GPU compute nodes that uses enroot to confirm end-to-end GPU functionality. The 4 checks have failed with error message expected due to #4144. In this case, failure indicates success - the tests fail when there is a broken element in the software stack.

These changes were manually tested with the changes in #4145 and the tests passed, indicating that both the test and the changes were successful.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@tpdownes tpdownes requested a review from samskillman May 19, 2025 19:30
@tpdownes tpdownes changed the title Improve Slurm GPU testing to include an invocation of enroot that tes… Improve Slurm GPU testing May 19, 2025
@tpdownes tpdownes marked this pull request as ready for review May 20, 2025 00:14
@tpdownes tpdownes requested a review from a team as a code owner May 20, 2025 00:14
@tpdownes tpdownes enabled auto-merge May 20, 2025 02:01
@tpdownes tpdownes added the release-chore To not include into release notes label May 20, 2025
@tpdownes tpdownes merged commit 4690446 into GoogleCloudPlatform:develop May 20, 2025
19 of 77 checks passed
@tpdownes tpdownes deleted the smarter_enroot_test branch May 20, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants