Block broken release of nvidia-container-toolkit#4145
Merged
tpdownes merged 1 commit intoMay 20, 2025
Merged
Conversation
The 1.17.7 release of nvidia-container-toolkit contains a regression which breaks running GPU-enabled jobs under enroot in Slurm. - NVIDIA/nvidia-container-toolkit#1091 - NVIDIA/nvidia-container-toolkit#1093 - NVIDIA/enroot#232 While we wait for an updated package, this configuration will block clusters from installing or upgrading to this package. If it is already installed, this change does nothing. It should be forward-compatible in the sense that it will not block new releases with sementically higher versions. This mitigates GoogleCloudPlatform#4144
samskillman
approved these changes
May 20, 2025
6ecc75b
into
GoogleCloudPlatform:release-candidate
21 of 69 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1.17.7 release of nvidia-container-toolkit contains a regression which breaks running GPU-enabled jobs under enroot in Slurm.
While we wait for an updated package, this configuration will block clusters from installing or upgrading to this package. If it is already installed, this change does nothing. It should be forward-compatible in the sense that it will not block new releases with sementically higher versions.
The specific file
nvidia-container-cliis installed during the build stage of Slurm, so I believe this should result in new clusters runningnvidia-container-toolkit=1.17.6-1(and other packages with similar names and identical version). When a version above 1.17.7-1 is released, the build process should naturally select those.This mitigates #4144
These changes were manually tested before/after #4146, which successfully identified the broken functionality.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.