Skip to content

Add A4 slurm blueprints#3709

Merged
harshthakkar01 merged 1 commit into
GoogleCloudPlatform:developfrom
harshthakkar01:a4-rc
Feb 26, 2025
Merged

Add A4 slurm blueprints#3709
harshthakkar01 merged 1 commit into
GoogleCloudPlatform:developfrom
harshthakkar01:a4-rc

Conversation

@harshthakkar01

@harshthakkar01 harshthakkar01 commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@harshthakkar01 harshthakkar01 self-assigned this Feb 24, 2025
@harshthakkar01 harshthakkar01 added the release-key-new-features Added to release notes under the "Key New Features" heading. label Feb 25, 2025
@rohitramu rohitramu changed the base branch from release-candidate to develop February 25, 2025 02:09
@harshthakkar01 harshthakkar01 force-pushed the a4-rc branch 5 times, most recently from 5476760 to 6adc02a Compare February 26, 2025 01:29
@harshthakkar01 harshthakkar01 marked this pull request as ready for review February 26, 2025 01:30
samskillman
samskillman previously approved these changes Feb 26, 2025
View reviewed changes

@samskillman samskillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a few more slight changes, but otherwise LGTM.

Comment thread examples/machine-learning/a4-highgpu-8g/a4high-slurm-blueprint.yaml
@harshthakkar01 harshthakkar01 force-pushed the a4-rc branch 2 times, most recently from 6789788 to 9b09bbb Compare February 26, 2025 06:32
samskillman
samskillman previously approved these changes Feb 26, 2025
View reviewed changes
@harshthakkar01 harshthakkar01 force-pushed the a4-rc branch 3 times, most recently from 01b8ce7 to 6e8c57e Compare February 26, 2025 17:29
@harshthakkar01 harshthakkar01 merged commit a453ef0 into GoogleCloudPlatform:develop Feb 26, 2025
RachaelSTamakloe pushed a commit to RachaelSTamakloe/hpc-toolkit that referenced this pull request Feb 26, 2025
@harshthakkar01 @RachaelSTamakloe
Merge pull request GoogleCloudPlatform#3709 from harshthakkar01/a4-rc
6ef461f 
Add A4 slurm blueprints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samskillman samskillman samskillman approved these changes

@chengcongdu chengcongdu Awaiting requested review from chengcongdu

@yuryu yuryu Awaiting requested review from yuryu

Assignees

@samskillman samskillman

Labels

release-key-new-features Added to release notes under the "Key New Features" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harshthakkar01 @samskillman