Skip to content

chore: LTS 5 versions#2343

Merged
burkedavison merged 23 commits intoGoogleCloudPlatform:masterfrom
burkedavison:lts-5-testing
Aug 1, 2023
Merged

chore: LTS 5 versions#2343
burkedavison merged 23 commits intoGoogleCloudPlatform:masterfrom
burkedavison:lts-5-testing

Conversation

@burkedavison
Copy link
Copy Markdown
Member

@burkedavison burkedavison commented Jun 26, 2023

No description provided.

@burkedavison
Copy link
Copy Markdown
Member Author

burkedavison commented Jun 26, 2023

I'm surprised this is passing. Locally, I get the following error:

[ERROR] Tests run: 22, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.888 s <<< FAILURE! - in com.google.cloud.tools.opensource.dependencies.DependencyGraphBuilderTest
[ERROR] testSetDetectedOsSystemProperties_netty4Dependency(com.google.cloud.tools.opensource.dependencies.DependencyGraphBuilderTest)  Time elapsed: 0.228 s  <<< FAILURE!
com.google.common.truth.AssertionErrorWithFacts: 
value of: getUnresolvedArtifacts()
expected to be empty
but was : [io.netty:netty-tcnative:jar:osx-x86_32:2.0.19.Final was not resolved. Dependency path: io.netty:netty-all:jar:4.1.31.Final (compile) > io.netty:netty-example:jar:4.1.31.Final (compile?) > io.netty:netty-tcnative:jar:osx-x86_32:2.0.19.Final (compile?), io.netty:netty-transport-native-kqueue:jar:osx-x86_32:4.1.31.Final was not resolved. Dependency path: io.netty:netty-all:jar:4.1.31.Final (compile) > io.netty:netty-transport-native-kqueue:jar:osx-x86_32:4.1.31.Final (compile?)]
        at com.google.cloud.tools.opensource.dependencies.DependencyGraphBuilderTest.testSetDetectedOsSystemProperties_netty4Dependency(DependencyGraphBuilderTest.java:296)

@suztomo
Copy link
Copy Markdown
Contributor

suztomo commented Jul 5, 2023 •
edited
Loading

It seems Mac specific error.

image

@burkedavison burkedavison changed the title chore: LTS 5 layer 1 versions chore: LTS 5 versions Jul 25, 2023
@suztomo
Copy link
Copy Markdown
Contributor

suztomo commented Jul 25, 2023

Nice nice if it can be solved. But the BOM doesn't get affected by Mac. I marked the check non-required.

@burkedavison
Copy link
Copy Markdown
Member Author

burkedavison commented Jul 31, 2023 •
edited
Loading

Display name in pull request Command in pull request comments Gradle goals Success?
Java SDK Post Commit Tests Run Java Postcommit :sdks:java:io:google-cloud-platform:postCommit Yes
Java_PVR_Flink_Batch Run Java_PVR_Flink_Batch PreCommit :runners:flink:1.13:job-server:validatesPortableRunnerBatch Yes
Java Spark PortableValidatesRunner Batch Tests Run Java Spark PortableValidatesRunner Batch :runners:spark:2:job-server:validatesPortableRunnerBatch, :runners:spark:3:job-server:validatesPortableRunnerBatch Yes
Dataflow V2 Java Post Commit Tests Run PostCommit_Java_DataflowV2 :runners:google-cloud-dataflow-java:validatesRunnerV2 Yes
Google Cloud Dataflow Runner V2 Java ValidatesRunner Tests Run Java Dataflow V2 ValidatesRunner Streaming :runners:google-cloud-dataflow-java:validatesRunnerV2Streaming Yes

@burkedavison burkedavison merged commit 8f5275e into GoogleCloudPlatform:master Aug 1, 2023
@burkedavison burkedavison deleted the lts-5-testing branch August 1, 2023 17:33
@Abacn Abacn mentioned this pull request Aug 2, 2023
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suztomo suztomo suztomo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@burkedavison @suztomo