Linkage Monitor to read content of a BOM#1920
Conversation
| artifactToVersion.put(model.getGroupId() + ":" + model.getArtifactId(), model.getVersion()); | ||
| String versionlessCoordinates = model.getGroupId() + ":" + model.getArtifactId(); | ||
| artifactToVersion.put(versionlessCoordinates, model.getVersion()); | ||
| logger.info("Found local artifact: " + model); |
There was a problem hiding this comment.
Updated this to fine. I needed this information when I was debugging #1919.
| String managedDependencyVersionlessCoordinates = | ||
| dependency.getGroupId() + ":" + dependency.getArtifactId(); | ||
| artifactToVersion.put(managedDependencyVersionlessCoordinates, dependency.getVersion()); | ||
| logger.info("Found local artifact in the BOM: " + dependency); |
There was a problem hiding this comment.
Updated this to fine. This information helps to identify why Linkage Monitor did not detect a problem.
| <dependency> | ||
| <groupId>com.google.api</groupId> | ||
| <artifactId>gax</artifactId> | ||
| <version>1.60.2-SNAPSHOT</version><!-- {x-version-update:gax:current} --> |
There was a problem hiding this comment.
we shouldn't need to version update the test data
| <artifactId>gax-bom</artifactId> | ||
| <version>1.60.2-SNAPSHOT</version><!-- {x-version-update:gax-bom:current} --> | ||
| <packaging>pom</packaging> | ||
| <name>GAX (Google Api eXtensions) for Java</name> |
There was a problem hiding this comment.
Most of this metadata isn't needed for the test
There was a problem hiding this comment.
Good point. Removed the unnecessary metadata.
| artifactToVersion.put(model.getGroupId() + ":" + model.getArtifactId(), model.getVersion()); | ||
| String versionlessCoordinates = model.getGroupId() + ":" + model.getArtifactId(); | ||
| artifactToVersion.put(versionlessCoordinates, model.getVersion()); | ||
| logger.info("Found local artifact: " + model); |
There was a problem hiding this comment.
Updated this to fine. I needed this information when I was debugging #1919.
| String managedDependencyVersionlessCoordinates = | ||
| dependency.getGroupId() + ":" + dependency.getArtifactId(); | ||
| artifactToVersion.put(managedDependencyVersionlessCoordinates, dependency.getVersion()); | ||
| logger.info("Found local artifact in the BOM: " + dependency); |
There was a problem hiding this comment.
Updated this to fine. This information helps to identify why Linkage Monitor did not detect a problem.
| <artifactId>gax-bom</artifactId> | ||
| <version>1.60.2-SNAPSHOT</version><!-- {x-version-update:gax-bom:current} --> | ||
| <packaging>pom</packaging> | ||
| <name>GAX (Google Api eXtensions) for Java</name> |
There was a problem hiding this comment.
Good point. Removed the unnecessary metadata.
| <dependency> | ||
| <groupId>com.google.api</groupId> | ||
| <artifactId>gax</artifactId> | ||
| <version>1.60.2-SNAPSHOT</version><!-- {x-version-update:gax:current} --> |
Fixes #1919