added support for gradle 4.10.3, 5.0, 5.1.1 and javac 11#437
added support for gradle 4.10.3, 5.0, 5.1.1 and javac 11#437chandanpasunoori wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
d77d745 to
b553f6a
Compare
|
CLAs look good, thanks! |
|
fixes #417 |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
bee446a to
df9406f
Compare
|
CLAs look good, thanks! |
df9406f to
ee2dfdf
Compare
ee2dfdf to
11f53c5
Compare
|
@loosebazooka you were nominated as a person on the Cloud Tools team who might be able to help us maintain the maven/gradle builders. |
|
We recommend using the official |
…orm#437) After this commit, aquasecurity/trivy@9c91da8#diff-3254677a7917c6c01f55212f86c57fbf, the trivy image will not have access to the docker socket and will not be able to write any scan output due to permissions issues. Another way I thought of to fix this was to change the user in the build step, but I don't see any documentation for how to do this in google cloud build.
Hi,
updated cloudbuild.yaml in gradle and javac to support gradle 4.10.3, 5.0, 5.1.1 and javac 11.
I used openjdk:11 for javac 11 because there is no 'launcher.gcr.io/google/openjdk11' available.
example spring builds are successful with Gradle 5.x and javac 11
please let me know if anything I need to do anything to for this merge.