Skip to content

added support for gradle 4.10.3, 5.0, 5.1.1 and javac 11#437

Closed
chandanpasunoori wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
chandanpasunoori:gradle5-java11
Closed

added support for gradle 4.10.3, 5.0, 5.1.1 and javac 11#437
chandanpasunoori wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
chandanpasunoori:gradle5-java11

Conversation

@chandanpasunoori
Copy link

Hi,

updated cloudbuild.yaml in gradle and javac to support gradle 4.10.3, 5.0, 5.1.1 and javac 11.
I used openjdk:11 for javac 11 because there is no 'launcher.gcr.io/google/openjdk11' available.

example spring builds are successful with Gradle 5.x and javac 11

please let me know if anything I need to do anything to for this merge.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@chandanpasunoori
Copy link
Author

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

CLAs look good, thanks!

@chandanpasunoori
Copy link
Author

fixes #417

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

CLAs look good, thanks!

@imjasonh
Copy link
Contributor

@loosebazooka you were nominated as a person on the Cloud Tools team who might be able to help us maintain the maven/gradle builders.

@imjasonh
Copy link
Contributor

imjasonh commented Feb 7, 2019

We recommend using the official gradle image directly. gradle:latest, which we will cache, currently points to gradle:5.2.0-jdk8 according to https://hub.docker.com/_/gradle

@imjasonh imjasonh closed this Feb 7, 2019
k0uki pushed a commit to OLTAInc/cloud-builders that referenced this pull request Oct 5, 2021
…orm#437)

After this commit,
aquasecurity/trivy@9c91da8#diff-3254677a7917c6c01f55212f86c57fbf,
the trivy image will not have access to the docker socket and will not be able
to write any scan output due to permissions issues.  Another way I thought of
to fix this was to change the user in the build step, but I don't see any
documentation for how to do this in google cloud build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants