Skip to content

Conversation

@sduskis
Copy link
Contributor

@sduskis sduskis commented Sep 19, 2016

The Spark samples are out of date and a bit broken. The Dataproc and Bigtable tables can not support this.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 19, 2016
The Spark samples are out of date and a bit broken.  The Dataproc and Bigtable tables can not support this.
@tswast
Copy link
Contributor

tswast commented Sep 19, 2016

LGTM

@lesv
Copy link
Contributor

lesv commented Sep 19, 2016

LGTM - Yep - saw the SPARK commentary. Curious how these ever worked.

@lesv lesv merged commit b9068b1 into GoogleCloudPlatform:master Sep 19, 2016
mbrukman pushed a commit to mbrukman/cloud-bigtable-examples that referenced this pull request Oct 12, 2016
* Initial empty repository
* Initialize the repository.

Adds shared pom.xml and google-checks.xml. I also add a test directory
to check that the pom works / is well-formed.

* Add Travis configuration.
* Remove unnecessary properties.
* Ignore generated AutoValue classes from checkstyle.
* Ignore JavaDoc rules in test classes.
* Ignore service account file.
* Add license header to POM
* Add instructions for using with subtrees.
Subtrees are the primary way I expect people to use the
`java-repo-tools` repository. Since it's not a super common workflow, I
document the needed steps in the README.
* Remove extra newline in README
* Remove another extra newline.
* Checkstyle fixes.

I modify the checkstyle config to have SAME_PACKAGE imports appear
before third-party imports. I think this better matches the intent of
the import ordering rules in the style guide.
https://google.github.io/styleguide/javaguide.html#s3.3.3-import-ordering-and-spacing
Expecially since it says the `com.google` imports only appear after
static imports if the source file is in the `com.google` package space.

(cherry picked from commit 7ca0e7564d4d1a39714d8c90e71d5e408f30f4da)

* Remove command that was copy-paste error.
The pulling changes from Java Repository Tools instructions can now be followed verbatim.
* Update README.md
* Add much easier steps for pulling in changes
The instructions here are much easier to follow and avoid unnecessary conflicts: https://help.github.com/articles/about-git-subtree-merges/
* Remove recommendation to create a branch.
* Added few more sample code for Search API. (GoogleCloudPlatform#173)
* Moved some checkstyle modules to java-repo-tools
* Moved some lines in .gitignore to the top level
* Add sample for App Engine  Datastore setDistinct projection queries.

Also update checkstyle to allow 1-letter variable names, since it
doesn't make sense to give long names to something like "arbitrary
column A that doesn't actually mean anything".

* Update coveralls plugin for code coverage analysis. (GoogleCloudPlatform#194)
* Use codecov for coverage. (GoogleCloudPlatform#199)
* Add Datastore indexes samples. (GoogleCloudPlatform#214)

Samples are moved from:
https://cloud.google.com/appengine/docs/java/datastore/indexes

Note: I add a new script `test-devserver.sh` to the testing config. This
script runs the `mvn appengine:devserver` plugin, waits for it to start,
then verifies that it gets a non-error response from the `/` path. I use
this to verify that the `datastore-indexes.xml` files are correct (by
disabling autoGenerate, the local devserver throws an error when a query
is used without the correct index defined, just as production does).

We should probably add any "hello world" or other projects to this
check, as well. Anywhere we say to run `mvn appengine:devserver`, it
would be good to test that it is correct.

* Use the subtree command to push changes upstream.
* Fix checkstyle errors in java/dataflow-coinbase sample.

This is an example of using the java-repo-tools parent pom in a sample.

To fix indentation and other simple errors, I ran the google-java-format
tool. https://github.com/google/google-java-format I still had to fix
imports, variable name, and javadoc checkstyle errors by hand.
@sduskis sduskis deleted the remove_spark branch June 7, 2017 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants