Use HttpStream.Wrapper for completion listener in JettyContainerService#79
Merged
copybara-service[bot] merged 3 commits intomainfrom Nov 9, 2023
Merged
Use HttpStream.Wrapper for completion listener in JettyContainerService#79copybara-service[bot] merged 3 commits intomainfrom
copybara-service[bot] merged 3 commits intomainfrom
Conversation
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
ludoch
reviewed
Nov 9, 2023
Collaborator
ludoch
left a comment
There was a problem hiding this comment.
Did you also check similar logic in prod runtime area for EE10? I guess EE8 is correct, right?
srinjoyray
pushed a commit
that referenced
this pull request
Nov 12, 2024
PiperOrigin-RevId: 580932773 Change-Id: I6741c74d7f10411cb184d97b0930797d93731929
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a
HttpStream.Wrapperfor the completion listener inJettyContainerService.We were previously using
Callbackfor theonCompletionevent inJettyContainerService, this tries to acquire all of the Semaphore permits to wait for all API calls to complete.However the callback is invoked before the the
HttpStream, and theSessionManageruses anHttpStream.Wrapperfor itsdoCompletewhich was eventually calling theDatastoreApiHelperwhich was event doing anApiProxycall.This fixes the EE10 guestbook app.