Skip to content

fix issues with non-writable temp directories#77

Merged
copybara-service[bot] merged 4 commits intomainfrom
tempDirectoryFix
Nov 8, 2023
Merged

fix issues with non-writable temp directories#77
copybara-service[bot] merged 4 commits intomainfrom
tempDirectoryFix

Conversation

@lachlan-roberts
Copy link
Copy Markdown
Collaborator

@lachlan-roberts lachlan-roberts commented Nov 8, 2023

some cleanups for temp directory creation

fixes the following error when deploying with EE10

java.lang.IllegalArgumentException: Temp dir /workspace not useable: writeable=false, dir=true
    at org.eclipse.jetty.server.handler.ContextHandler.createTempDirectory(ContextHandler.java:702)
    at org.eclipse.jetty.ee10.webapp.WebAppContext.createTempDirectory(WebAppContext.java:472)
    at org.eclipse.jetty.ee10.webapp.WebInfConfiguration.preConfigure(WebInfConfiguration.java:63)
    at org.eclipse.jetty.ee10.webapp.Configurations.preConfigure(Configurations.java:487)
    at org.eclipse.jetty.ee10.webapp.WebAppContext.preConfigure(WebAppContext.java:454)
    at org.eclipse.jetty.ee10.webapp.WebAppContext.doStart(WebAppContext.java:495)
    at com.google.apphosting.runtime.jetty.ee10.AppEngineWebAppContext.doStart(AppEngineWebAppContext.java:212)

@lachlan-roberts
stop using non-writable temp directories
07ba3f6 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
fix naming of async property field
f01853a 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
fix naming of async property field
de7515a 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
some fixes to AppEngineWebAppContextTest
9796e66 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@copybara-service copybara-service bot merged commit b8e030f into main Nov 8, 2023
@lachlan-roberts lachlan-roberts deleted the tempDirectoryFix branch January 11, 2024 01:27
srinjoyray pushed a commit that referenced this pull request Nov 12, 2024
@gae-java-bot
Merge pull request #77 from GoogleCloudPlatform:tempDirectoryFix
6d9aeba 
PiperOrigin-RevId: 580551190
Change-Id: I418d4b2bea3c8d03353b81939647f048997ce810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregw gregw Awaiting requested review from gregw

@ludoch ludoch Awaiting requested review from ludoch

Assignees

No one assigned

Labels

ready to pull

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lachlan-roberts @ludoch