Issue #251 - mark baseRequest as secure for HttpConnector mode with Jetty9.4 runtimes #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etty9.4 runtimes Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
ludoch
approved these changes
Jul 19, 2024
srinjoyray
pushed a commit
that referenced
this pull request
Nov 12, 2024
…nnectorMode PiperOrigin-RevId: 653875419 Change-Id: Ie953edcf1ec99944300a301259b87050e079f1d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #251
We wrapped the
HttpServletResponseto mark it as secure but in9.4it is necessary to do this for thebaseRequestas well.Also parameterize the
TransportGuaranteeTestover the jetty94/ee8/ee10 runtimes and HttpConnector modes.