Change Write Disposition from WRITE_TRUNCATE to WRITE_APPEND#96
Merged
ryanmcdowell merged 1 commit intoGoogleCloudPlatform:masterfrom Apr 13, 2020
Merged
Change Write Disposition from WRITE_TRUNCATE to WRITE_APPEND#96ryanmcdowell merged 1 commit intoGoogleCloudPlatform:masterfrom
ryanmcdowell merged 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
Setting a default template to delete all existing data in a BQ table not only limits its use, but is also a bit dangerous (as I just found out, all my existing data was gone when I started using Dataflow). Setting it to Append instead makes the template more useful. Most people who end up using this template probably want to schedule Dataflow to incrementally new data as it arrives. The trucation at the moment is a dangerous side effect, as someone running this template would have no clue they are going to lose all existing data by using this template.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Contributor
Author
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
sabhyankar
approved these changes
Apr 13, 2020
Member
sabhyankar
left a comment
There was a problem hiding this comment.
Thanks @ramnathnayakpr
LGTM
|
By changing the WRITE_DISPOSITION option, this code is not coherent with what is explained in the Google documentation: It could be a nice feature to add WRITE_DISPOSITION as a template parameter. |
shreyakhajanchi
pushed a commit
that referenced
this pull request
Feb 11, 2025
* Add IT for Cassandra (#86) * Add IT for Cassandra Reverse Replication * Added IT Fixes * Added IT fixes * removed logger * removed unwanted system log * Handle Catch * Handle with safehandler * Running load test * revert unwanted commit * Added IT FIXES * Added UT and removed unwanted SOUT * Added One to Many Datatype Transformation for IT (#90) Added One to Many Datatype Transformation for IT Fix PR review comments * Handle IT for MYSQL * Added ByteBuffer TO BigInteger * Cassandra rr custom transfornation it test (#96) * PR Review Comments (#97) * Splotless fixes * Handle Retry Missing Exception Category * Rebase Issue fixes --------- Co-authored-by: pawankashyapollion <v-pawan.kumar@ollion.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting a default template to delete all existing data in a BQ table not only limits its use, but is also a bit dangerous (as I just found out, all my existing data was gone when I started using Dataflow). Setting it to Append instead makes the template more useful. Most people who end up using this template probably want to schedule Dataflow to incrementally new data as it arrives. The trucation at the moment is a dangerous side effect, as someone running this template would have no clue they are going to lose all existing data by using this template.