Support read of repeated string fields in BigQuery#68
Closed
larsbkrogvig wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Closed
Support read of repeated string fields in BigQuery#68larsbkrogvig wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
larsbkrogvig wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Author
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
sabhyankar
requested changes
Nov 4, 2019
Member
sabhyankar
left a comment
There was a problem hiding this comment.
Thank you for the PR! Can you take a look at the comments and make the necessary corrections?
Comment on lines
+388
to
416
| switch (column.getMode()) { | ||
| case "NULLABLE": | ||
| case "REQUIRED": | ||
| String strValue = columnValue.toString(); | ||
| valueBuilder.setStringValue(strValue); | ||
| boolean excludeFromIndexes = strValue.getBytes().length > MAX_STRING_SIZE_BYTES; | ||
| valueBuilder.setExcludeFromIndexes(excludeFromIndexes); | ||
| break; | ||
|
|
||
| case "REPEATED": | ||
|
|
||
| ArrayValue.Builder arrayValueBuilder = ArrayValue.newBuilder(); | ||
| boolean excludeArrayFromIndexes = false; | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| List<Object> objectList = (List<Object>) columnValue; | ||
| for (Object object: objectList) { | ||
| String arrayStringValue = object.toString(); | ||
| if (arrayStringValue.getBytes().length > MAX_STRING_SIZE_BYTES) { | ||
| excludeArrayFromIndexes = true; | ||
| } | ||
| arrayValueBuilder.addValues(Value.newBuilder().setStringValue(arrayStringValue).build()); | ||
| } | ||
| valueBuilder.setArrayValue(arrayValueBuilder.build()); | ||
| valueBuilder.setExcludeFromIndexes(excludeArrayFromIndexes); | ||
| break; | ||
|
|
||
| } | ||
| break; |
Member
There was a problem hiding this comment.
If I am reading this correctly, we are only handling REQUIRED and REPEATED fields for STRING types? Why not extend this to the other supported data types (INT64, FLOAT etc)?
| valueBuilder.setStringValue(strValue); | ||
| boolean excludeFromIndexes = strValue.getBytes().length > MAX_STRING_SIZE_BYTES; | ||
| valueBuilder.setExcludeFromIndexes(excludeFromIndexes); | ||
| switch (column.getMode()) { |
Member
There was a problem hiding this comment.
Lets add unit test coverage as well.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
shreyakhajanchi
pushed a commit
that referenced
this pull request
Jan 23, 2025
* Dml integration (#53) * Added extensive UT Added extensive UT * Cassandra pr bug fixes (#57) * Cassandra Consolidate Unit Test case and Regression testing fixes (#58) * Added Mapping fixes * Added Spoltles fixes * Added Consolidated fixes * Added TODO * Addess Data and Time * Cassandra pr bug fixes (#64) * Handle TypeHandler Parsing issue fixes (#65) Co-authored-by: pawankashyapollion <v-pawan.kumar@ollion.com> * Added Safe handle (#68) * Handle LocalTime For Time Data Type In Cassandra (#69) * Cassandra pr bug fixes (#70) * Handle Timestamp Fixes (#72) * Added Code Combined in a single way * Address The Unwanted Hop * Cassandra pr bug fixes (#75) * Added PR Review Comments * Remove NamesCol Dependecy as spannerTableName is same as In Given Mapping * Added spannerTableId for fetching Mapping * Removed SpannerToID and also Updated Session file with proper structure * Timestamp in milisecond * removed assertNotNull from UT wherever possible * Added Fixes * Added Note Instead of Question * -- review fixes (#78) * Added Bytes to hex to blob conversion * Handling Bytes as Binary encoded As of now * Passing Null Value to Primary Key as well for cassandra * Added UT fixes * Added UT refectoring * Reverse merge confict fixes --------- Co-authored-by: pawankashyapollion <v-pawan.kumar@ollion.com> Co-authored-by: Akash Thawait <aakash@ollion.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to read a repeated string field from BigQuery, but there is no check for field mode in the
BigQueryConvertersclass.This adds such a check for
STRINGfields only. This should be made more general, though,