WideRowHandling: spanner to source db IT#2252
Merged
asthamohta merged 15 commits intoGoogleCloudPlatform:mainfrom Apr 22, 2025
Merged
WideRowHandling: spanner to source db IT#2252asthamohta merged 15 commits intoGoogleCloudPlatform:mainfrom
asthamohta merged 15 commits intoGoogleCloudPlatform:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2252 +/- ##
============================================
- Coverage 49.19% 49.18% -0.01%
- Complexity 4620 4951 +331
============================================
Files 924 924
Lines 55852 55852
Branches 5998 5998
============================================
- Hits 27475 27472 -3
Misses 26403 26403
- Partials 1974 1977 +3
🚀 New features to boost your workflow:
|
asthamohta
reviewed
Mar 26, 2025
.../java/com/google/cloud/teleport/v2/templates/SpannerToCassandraSourceDbMaxColumnsSizeIT.java
Outdated
Show resolved
Hide resolved
asthamohta
previously approved these changes
Apr 11, 2025
...db/src/test/java/com/google/cloud/teleport/v2/templates/SpannerToSourceDbWideRowBasicIT.java
Outdated
Show resolved
Hide resolved
...-sourcedb/src/test/resources/SpannerToSourceDbWideRowIT/spanner-max-col-cassandra-schema.sql
Outdated
Show resolved
Hide resolved
Contributor
|
Hi @VardhanThigle PR comments have been resolved. Please review and rerun the pipeline. |
7131b4a to
757988d
Compare
* Added allowes Packet Size * Added and remove unwanted Boundry Check
* Added allowes Packet Size * Added and remove unwanted Boundry Check * Added Foxes for Max in Size IT * Added Fixes for max cols * Added 10mb * Added Fixes * Added Fixes * Spotless fixes * Added Fixes * Added FIxes * removed unwanted
6bb351d to
90d0bbc
Compare
asthamohta
approved these changes
Apr 21, 2025
ron-gal
pushed a commit
to ron-gal/DataflowTemplates
that referenced
this pull request
Apr 25, 2025
* Wide row rr handling (GoogleCloudPlatform#148) * Resolve Merge Conflict * resolve merge conflict * Wide row rr fixes (GoogleCloudPlatform#155) * Added allowes Packet Size * Added and remove unwanted Boundry Check * IT Resource Exhausted Fixes * Added allowes Packet Size * Added and remove unwanted Boundry Check * Added Foxes for Max in Size IT * Added Fixes for max cols * Added 10mb * Added Fixes * Added Fixes * Spotless fixes * Added Fixes * Added FIxes * removed unwanted * updated the Comments * PR Review comment fixes * rename function * update comments * Added CopyRight Fixes * Removed and Cleanup code (GoogleCloudPlatform#194) * fix checkstyle * fix schema creation for N columns * fix changestream issue * widerow: add missing changes --------- Co-authored-by: pawankashyapollion <v-pawan.kumar@ollion.com> Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces validation checks to enforce various constraints on table and column creation, ensuring compliance with database limitations.
Changes Implemented
Table Name Length Constraint (1 to 128 characters)
Maximum Columns per Table (1,024)
Column Name Length Constraint (1 to 128 characters)
String Cell Size Constraint (Max 2,621,440 Unicode characters)