Skip to content

Remove sdk_container_image example from terraform.tfvars#2187

Merged
manitgupta merged 1 commit intoGoogleCloudPlatform:mainfrom
manitgupta:fix_sdk_container
Feb 21, 2025
Merged

Remove sdk_container_image example from terraform.tfvars#2187
manitgupta merged 1 commit intoGoogleCloudPlatform:mainfrom
manitgupta:fix_sdk_container

Conversation

@manitgupta
Copy link
Copy Markdown
Member

No description provided.

@manitgupta manitgupta requested a review from a team as a code owner February 13, 2025 06:20
@manitgupta manitgupta added the improvement Making existing code better label Feb 13, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.34%. Comparing base (b51c933) to head (2ebc6c0).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2187      +/-   ##
============================================
+ Coverage     47.05%   55.34%   +8.28%     
+ Complexity     4049     1641    -2408     
============================================
  Files           876      409     -467     
  Lines         52230    22213   -30017     
  Branches       5507     2205    -3302     
============================================
- Hits          24578    12293   -12285     
+ Misses        25892     9203   -16689     
+ Partials       1760      717    -1043     
Components Coverage Δ
spanner-templates 70.41% <ø> (+1.49%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 76.48% <ø> (ø)
spanner-live-reverse-replication 78.80% <ø> (ø)
spanner-bulk-migration 87.94% <ø> (ø)

see 484 files with indirect coverage changes

@manitgupta
Copy link
Copy Markdown
Member Author

This change is unrelated to the template code and does not impact how ITs will fail or succeed.

@manitgupta manitgupta merged commit c50e626 into GoogleCloudPlatform:main Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Making existing code better size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants