Skip to content

Cassandra Reverse Replication - Integration Tests#2155

Merged
shreyakhajanchi merged 20 commits intoGoogleCloudPlatform:mainfrom
ollionorg:casssandra_rr_integration_tests
Feb 11, 2025
Merged

Cassandra Reverse Replication - Integration Tests#2155
shreyakhajanchi merged 20 commits intoGoogleCloudPlatform:mainfrom
ollionorg:casssandra_rr_integration_tests

Conversation

@taherkl
Copy link
Copy Markdown
Contributor

@taherkl taherkl commented Jan 28, 2025 •
edited
Loading

  1. Handle Integration test for different Table from Spanner to one Table in cassandra Insert Query
  2. Handle Integration test for One table in spanner which support all of the data type conversion to cassandra
  3. Handle Integration test for One table in spanner which support all of the one to many data type conversion to cassandra.

@pawankashyapollion
Add IT for Cassandra (#86)
db1f627 
* Add IT for Cassandra Reverse Replication
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.96%. Comparing base (dae14d7) to head (1dab953).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##               main    #2155    +/-   ##
==========================================
  Coverage     46.95%   46.96%            
- Complexity     4043     4372   +329     
==========================================
  Files           876      876            
  Lines         52154    52194    +40     
  Branches       5477     5502    +25     
==========================================
+ Hits          24489    24513    +24     
- Misses        25912    25924    +12     
- Partials       1753     1757     +4
Components Coverage Δ
spanner-templates 68.91% <100.00%> (+0.02%) ⬆️
spanner-import-export 65.72% <ø> (+<0.01%) ⬆️
spanner-live-forward-migration 76.50% <ø> (ø)
spanner-live-reverse-replication 78.77% <100.00%> (+0.10%) ⬆️
spanner-bulk-migration 87.94% <ø> (ø)
Files with missing lines Coverage Δ
...oud/teleport/v2/utils/DatastreamToPostgresDML.java 56.75% <ø> (ø)
...v2/templates/dbutils/dml/CassandraTypeHandler.java 84.34% <100.00%> (+2.38%) ⬆️
...leport/v2/templates/transforms/SourceWriterFn.java 85.21% <ø> (ø)

... and 16 files with indirect coverage changes

@taherkl taherkl marked this pull request as ready for review January 30, 2025 11:30
@taherkl taherkl requested a review from a team as a code owner January 30, 2025 11:30
shreyakhajanchi
shreyakhajanchi reviewed Jan 31, 2025
View reviewed changes
Comment thread ...edb/src/test/java/com/google/cloud/teleport/v2/templates/CassandraSharedResourceManager.java Outdated
Comment thread ...edb/src/test/java/com/google/cloud/teleport/v2/templates/CassandraSharedResourceManager.java Outdated
Comment thread ...ner-to-sourcedb/src/test/resources/SpannerToCassandraSourceDbDatatypeIT/cassandra-schema.sql Outdated
Comment thread ...ourcedb/src/test/java/com/google/cloud/teleport/v2/templates/SpannerToCassandraDbITBase.java Outdated
Comment thread ...c/test/java/com/google/cloud/teleport/v2/templates/SpannerToCassandraSourceDbDatatypeIT.java Outdated
Comment thread ...c/test/java/com/google/cloud/teleport/v2/templates/SpannerToCassandraSourceDbDatatypeIT.java Outdated
Comment thread ...c/test/java/com/google/cloud/teleport/v2/templates/SpannerToCassandraSourceDbDatatypeIT.java Outdated
@pawankashyapollion
Added One to Many Datatype Transformation for IT (#90)
7d288f0 
Added One to Many Datatype Transformation for IT
Fix PR review comments
shreyakhajanchi
shreyakhajanchi reviewed Feb 6, 2025
View reviewed changes
Comment thread ...-sourcedb/src/test/java/com/google/cloud/teleport/v2/templates/CassandraResourceManager.java Outdated
Comment thread ...-sourcedb/src/test/java/com/google/cloud/teleport/v2/templates/CassandraResourceManager.java
Comment thread ...rcedb/src/test/java/com/google/cloud/teleport/v2/templates/SpannerToCassandraSourceDbIT.java
Comment thread ...rcedb/src/test/java/com/google/cloud/teleport/v2/templates/SpannerToCassandraSourceDbIT.java Outdated
Comment thread ...rcedb/src/test/java/com/google/cloud/teleport/v2/templates/SpannerToCassandraSourceDbIT.java Outdated
Comment thread ...rcedb/src/test/java/com/google/cloud/teleport/v2/templates/SpannerToCassandraSourceDbIT.java
shreyakhajanchi
shreyakhajanchi reviewed Feb 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@shreyakhajanchi shreyakhajanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CassandraIT is failing in github action with error Caused by: com.google.cloud.spanner.SpannerException: FAILED_PRECONDITION: io.grpc.StatusRuntimeException: FAILED_PRECONDITION: Wrong number of key parts for users. Expected: 1. Got: ["1","3"] please check and fix the IT

Comment thread ...rcedb/src/test/java/com/google/cloud/teleport/v2/templates/SpannerToCassandraSourceDbIT.java
Comment thread ...rcedb/src/test/java/com/google/cloud/teleport/v2/templates/SpannerToCassandraSourceDbIT.java
@pawankashyapollion
Copy link
Copy Markdown
Contributor

pawankashyapollion commented Feb 10, 2025

The CassandraIT is failing in github action with error Caused by: com.google.cloud.spanner.SpannerException: FAILED_PRECONDITION: io.grpc.StatusRuntimeException: FAILED_PRECONDITION: Wrong number of key parts for users. Expected: 1. Got: ["1","3"] please check and fix the IT

@shreyakhajanchi we have identified and fixed the issue

@pawankashyapollion pawankashyapollion requested a review from a team as a code owner February 10, 2025 08:45
shreyakhajanchi
shreyakhajanchi reviewed Feb 11, 2025
View reviewed changes
Comment thread ...astream-to-sql/src/main/java/com/google/cloud/teleport/v2/utils/DatastreamToPostgresDML.java Outdated
Comment thread ...rcedb/src/test/java/com/google/cloud/teleport/v2/templates/SpannerToCassandraSourceDbIT.java
@shreyakhajanchi shreyakhajanchi merged commit 1e284fe into GoogleCloudPlatform:main Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VardhanThigle VardhanThigle VardhanThigle left review comments

@shreyakhajanchi shreyakhajanchi shreyakhajanchi approved these changes

@bharadwaj-aditya bharadwaj-aditya Awaiting requested review from bharadwaj-aditya bharadwaj-aditya is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

+1 more reviewer

@pawankashyapollion pawankashyapollion pawankashyapollion left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ignore-for-release size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@taherkl @pawankashyapollion @VardhanThigle @shreyakhajanchi