Fixing TypeMismatch in Cassandra Driver Config Loader#2118
Merged
VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom Jan 9, 2025
Merged
Fixing TypeMismatch in Cassandra Driver Config Loader#2118VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom
VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
ae86b0e to
35d2b8e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2118 +/- ##
============================================
+ Coverage 46.58% 54.68% +8.10%
+ Complexity 3960 1574 -2386
============================================
Files 869 401 -468
Lines 51599 21725 -29874
Branches 5403 2156 -3247
============================================
- Hits 24036 11881 -12155
+ Misses 25844 9147 -16697
+ Partials 1719 697 -1022
|
35d2b8e to
85d7e9f
Compare
.../java/com/google/cloud/teleport/v2/spanner/migrations/utils/CassandraDriverConfigLoader.java
Show resolved
Hide resolved
dc16449 to
8dc6c58
Compare
8dc6c58 to
66f75ae
Compare
shreyakhajanchi
approved these changes
Jan 9, 2025
Contributor
Author
|
Unrelated IT failure |
pawankashyapollion
pushed a commit
to ollionorg/DataflowTemplates-fork
that referenced
this pull request
Jan 10, 2025
akashthawaitcc
pushed a commit
to ollionorg/DataflowTemplates-fork
that referenced
this pull request
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Cassandra DriverExecutionProfile#entrySet returns SortedSet<Map.Entry<String,Object>> which seems to stringify types like duration and cant be directly passed to the strongly typed OptionsMap.html#put call.
We need a small amount of type mapping/adaptation for the same.