PipelineController Changes for Cassandra Bulk#2086
Merged
VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom Dec 31, 2024
Merged
PipelineController Changes for Cassandra Bulk#2086VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom
VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
9e43970 to
d71542c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2086 +/- ##
============================================
+ Coverage 46.40% 54.37% +7.97%
+ Complexity 3932 1553 -2379
============================================
Files 859 393 -466
Lines 51300 21419 -29881
Branches 5394 2146 -3248
============================================
- Hits 23804 11646 -12158
+ Misses 25783 9081 -16702
+ Partials 1713 692 -1021
|
f97e38d to
ec72243
Compare
ec72243 to
59670fb
Compare
VardhanThigle
commented
Dec 30, 2024
...rcedb-to-spanner/src/main/java/com/google/cloud/teleport/v2/templates/DbConfigContainer.java
Show resolved
Hide resolved
VardhanThigle
commented
Dec 30, 2024
...cedb-to-spanner/src/main/java/com/google/cloud/teleport/v2/templates/PipelineController.java
Show resolved
Hide resolved
59670fb to
07b18f6
Compare
07b18f6 to
2fd3106
Compare
bharadwaj-aditya
previously approved these changes
Dec 31, 2024
Contributor
bharadwaj-aditya
left a comment
There was a problem hiding this comment.
Minor suggestions. LGTM overall.
...rcedb-to-spanner/src/main/java/com/google/cloud/teleport/v2/templates/DbConfigContainer.java
Show resolved
Hide resolved
...rcedb-to-spanner/src/main/java/com/google/cloud/teleport/v2/templates/SourceDbToSpanner.java
Outdated
Show resolved
Hide resolved
2fd3106 to
7a0349f
Compare
taherkl
pushed a commit
to ollionorg/DataflowTemplates-fork
that referenced
this pull request
Jan 2, 2025
taherkl
pushed a commit
to ollionorg/DataflowTemplates-fork
that referenced
this pull request
Jan 2, 2025
shreyakhajanchi
pushed a commit
that referenced
this pull request
Jan 7, 2025
* Added Connection Helper * Added Formatter * Added File Reader * Refectored * Added Changes for Schema and Spanner Schema * Added Schema Changes to read Spanner Table in Schema object * Added Schema Changes * Added Changes for Schma * Added Source Writn Fn Changes * Added Source Factory Changes * Added Fixed for the Source factory and Casssandra Connection helper * Added Cassandra Schema Reader * Added Pipeline Process * Removed Unwanted Validation * Added Access validator * removed unwanted Return * Added Thread safe optimization in cassandra Connection helper * Applied spotless:apply * spotless:apply * Added Constructor for Test case * Added DUMMY Generator For UT * Fixed UT for Metadata config (#30) Co-authored-by: Narendra Rajput <narendra.rajput@ollion.com> Cassandra metadata PR To accomodate Driver Loader Class (#33) * Removed * * Create README.md for UDF samples (#2083) This commit adds a README.md file to the directory. The README file provides descriptions for each of the sample Javascript UDF files in the directory, including their purpose and usage examples. Co-authored-by: labs-code-app[bot] <161369871+labs-code-app[bot]@users.noreply.github.com> * CassandraDriverConfigLoader from GCS (#2077) * Added Config File Path * Added Fix for Loading Driver Options * Added Dependecy Fixes * Fix UT --------- Co-authored-by: labs-code-app[bot] <161369871+labs-code-app[bot]@users.noreply.github.com> Co-authored-by: Vardhan Vinay Thigle <39047439+VardhanThigle@users.noreply.github.com> * PR Review Comments (#35) * Convert it to builder Pattern * Convert Waring to Error * remove the unwanted comments * Removed Unwanted options * Address the PR * Address the PR Comments * Added Missing Getter for Configuration * Address to removed configuration changes * removed unwanted getters * Removal of getter from cassandra dao and test case fixes * Handle Optionmap in cassandra DAO for serialization * removed dependecy of getKeyOrder * Removed And Update Exception * Fix Checkstyle Voilation * Missing UT Added (#37) * Added Dummy Test case * Removed * from import * removed unwanted * Added Fixes * Added test case and fixes * Added Some more PR comments * Added Test case for Cassandra Reader * Added New testcase * Added Dependecny * Update test case and remove Dependency of Jupiter (#39) * Update test case and remove Dependecy of jupiter * Added UT fixes * Added Missing Getter for Configuration * [Sourcedb-to-spanner] Bulk migration Mysql to spanner 1tb Load test (#2063) * [Sourcedb-to-spanner] Bulk migration Mysql to spanner 1tb Load test * Updating row counts, added static sql resources * Renaming the test and addressing comments * PipelineController Changes for Cassandra (#2086) * Fix Spanner Load tests and add display test report (#2092) * correcting lt failures * Adding test report * Meta code coverage (#41) Meta code coverage * Pr bug fixes (#42) * Schema Reader Optimization (#43) * Added Pr Fix related to Changes Year in Javadoc * Address the revert of 2025 and removal of extra constructor * Added Extra Testcase to reach target patch --------- Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Co-authored-by: pawankashyapollion <v-pawan.kumar@ollion.com> Co-authored-by: labs-code-app[bot] <161369871+labs-code-app[bot]@users.noreply.github.com> Co-authored-by: Vardhan Vinay Thigle <39047439+VardhanThigle@users.noreply.github.com> Co-authored-by: darshan-sj <darshan-sj@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring changes in PipelineController to accommodate Cassandra Source.