feat: drop node target's key constraint requirement#2068
Merged
liferoad merged 1 commit intoGoogleCloudPlatform:mainfrom Jan 8, 2025
Merged
feat: drop node target's key constraint requirement#2068liferoad merged 1 commit intoGoogleCloudPlatform:mainfrom
liferoad merged 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2068 +/- ##
============================================
- Coverage 46.16% 46.14% -0.02%
+ Complexity 3843 3835 -8
============================================
Files 856 855 -1
Lines 51010 50996 -14
Branches 5365 5363 -2
============================================
- Hits 23548 23532 -16
- Misses 25760 25762 +2
Partials 1702 1702
|
Emrehzl94
approved these changes
Dec 16, 2024
ali-ince
approved these changes
Dec 17, 2024
Contributor
ali-ince
left a comment
There was a problem hiding this comment.
Looks good! Are the tests failures related to this change?
Collaborator
Author
|
The test failures are all about the Neo4j container timing out: One occurrence of this is: Maybe a temporary issue on the CI side? |
This blocks Community Edition (CE) users, as the only way to emulate key constraints is to combine unique constraints (available in CE) with existence constraints (available only in Enterprise Edition).
efbcdc9 to
924cd4c
Compare
liferoad
approved these changes
Jan 8, 2025
pawankashyapollion
pushed a commit
to ollionorg/DataflowTemplates-fork
that referenced
this pull request
Jan 10, 2025
…orm#2068) This blocks Community Edition (CE) users, as the only way to emulate key constraints is to combine unique constraints (available in CE) with existence constraints (available only in Enterprise Edition).
fbiville
added a commit
to fbiville/DataflowTemplates
that referenced
this pull request
Jan 13, 2025
…oudPlatform#2068)" This reverts commit 6804d64.
liferoad
pushed a commit
that referenced
this pull request
Jan 13, 2025
darshan-sj
pushed a commit
that referenced
this pull request
Jan 15, 2025
pawankashyapollion
pushed a commit
to ollionorg/DataflowTemplates-fork
that referenced
this pull request
Jan 15, 2025
pawankashyapollion
pushed a commit
to ollionorg/DataflowTemplates-fork
that referenced
this pull request
Jan 16, 2025
…orm#2068) This blocks Community Edition (CE) users, as the only way to emulate key constraints is to combine unique constraints (available in CE) with existence constraints (available only in Enterprise Edition).
pawankashyapollion
pushed a commit
to ollionorg/DataflowTemplates-fork
that referenced
this pull request
Jan 16, 2025
akashthawaitcc
pushed a commit
to ollionorg/DataflowTemplates-fork
that referenced
this pull request
Jan 23, 2025
…orm#2068) This blocks Community Edition (CE) users, as the only way to emulate key constraints is to combine unique constraints (available in CE) with existence constraints (available only in Enterprise Edition).
akashthawaitcc
pushed a commit
to ollionorg/DataflowTemplates-fork
that referenced
this pull request
Jan 23, 2025
pawankashyapollion
pushed a commit
to ollionorg/DataflowTemplates-fork
that referenced
this pull request
Jan 23, 2025
…orm#2068) This blocks Community Edition (CE) users, as the only way to emulate key constraints is to combine unique constraints (available in CE) with existence constraints (available only in Enterprise Edition).
pawankashyapollion
pushed a commit
to ollionorg/DataflowTemplates-fork
that referenced
this pull request
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This blocks Community Edition (CE) users, as the only way to emulate key constraints is to combine unique constraints (available in CE) with existence constraints (available only in Enterprise Edition).