Skip to content

Favor built-in transform over custom one#2013

Merged
liferoad merged 1 commit intoGoogleCloudPlatform:mainfrom
fbiville:neo4j/with-keys
Jan 8, 2025
Merged

Favor built-in transform over custom one#2013
liferoad merged 1 commit intoGoogleCloudPlatform:mainfrom
fbiville:neo4j/with-keys

Conversation

@fbiville
Copy link
Copy Markdown
Collaborator

This replaces our custom KV transform, since Beam already includes one.

Copy link
Copy Markdown
Contributor

@ali-ince ali-ince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.15%. Comparing base (cd28d01) to head (fff1207).

Files with missing lines Patch % Lines
...t/v2/neo4j/transforms/Neo4jRowWriterTransform.java 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2013      +/-   ##
============================================
- Coverage     46.16%   46.15%   -0.01%     
+ Complexity     3843     3836       -7     
============================================
  Files           856      855       -1     
  Lines         51010    50994      -16     
  Branches       5365     5363       -2     
============================================
- Hits          23548    23536      -12     
+ Misses        25760    25754       -6     
- Partials       1702     1704       +2     
Components Coverage Δ
spanner-templates 67.88% <ø> (-0.02%) ⬇️
spanner-import-export 65.56% <ø> (-0.04%) ⬇️
spanner-live-forward-migration 76.42% <ø> (ø)
spanner-live-reverse-replication 77.35% <ø> (ø)
spanner-bulk-migration 87.16% <ø> (ø)
Files with missing lines Coverage Δ
...t/v2/neo4j/transforms/Neo4jRowWriterTransform.java 67.39% <85.71%> (+1.11%) ⬆️

... and 2 files with indirect coverage changes

@fbiville fbiville added the improvement Making existing code better label Nov 15, 2024
This replaces our custom KV transform, since Beam already includes
one.
@liferoad liferoad merged commit c78618b into GoogleCloudPlatform:main Jan 8, 2025
pawankashyapollion pushed a commit to ollionorg/DataflowTemplates-fork that referenced this pull request Jan 10, 2025
This replaces our custom KV transform, since Beam already includes
one.
akashthawaitcc pushed a commit to ollionorg/DataflowTemplates-fork that referenced this pull request Jan 23, 2025
This replaces our custom KV transform, since Beam already includes
one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Making existing code better size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants