Skip to content

removed deprecated reverse replication templates#1413

Closed
aksharauke wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
aksharauke:rr
Closed

removed deprecated reverse replication templates#1413
aksharauke wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
aksharauke:rr

Conversation

@aksharauke
Copy link
Copy Markdown
Contributor

removed deprecated reverse replication templates

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2024

Codecov Report

Merging #1413 (2c59830) into main (dba7f52) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 2c59830 differs from pull request most recent head bf63b64. Consider uploading reports for the commit bf63b64 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1413      +/-   ##
============================================
+ Coverage     39.60%   39.62%   +0.01%     
- Complexity     2694     2697       +3     
============================================
  Files           714      714              
  Lines         40919    40918       -1     
  Branches       4419     4419              
============================================
+ Hits          16207    16212       +5     
+ Misses        23261    23256       -5     
+ Partials       1451     1450       -1     
Components Coverage Δ
spanner-templates 53.58% <ø> (+0.02%) ⬆️
spanner-import-export 65.57% <ø> (+0.06%) ⬆️
spanner-live-forward-migration 57.79% <ø> (ø)
spanner-live-reverse-replication 39.01% <ø> (-0.02%) ⬇️
spanner-bulk-migration 62.78% <ø> (ø)

see 4 files with indirect coverage changes

@manitgupta manitgupta added the Google LGTM Approval of a pull request to be merged into the repository label Apr 4, 2024
@aksharauke aksharauke requested a review from a team as a code owner April 15, 2024 07:25
@aksharauke aksharauke requested review from asthamohta and darshan-sj and removed request for a team April 15, 2024 07:25
@aksharauke aksharauke force-pushed the rr branch 4 times, most recently from 451a95b to 233ab4c Compare April 18, 2024 09:29
Get consistent java-pr signal on main

Default to THROUGHPUT_BASED autoscaling for classic templates (GoogleCloudPlatform#1403)

* single commit off of master

* No-op comment change to kick copybara

* Revert "No-op comment change to kick copybara"

This reverts commit 928dc6b.

* Different no-op to kick copybara and avoid conflicts

* One more try to get copybara to merge

Support FLOAT32 type in v1 templates of Spanner. (GoogleCloudPlatform#1376)

Squashed commit of the following:

commit 1e21615
Merge: 5764ef8 27e7486
Author: Aravind Pedapudi <aravindp1510@gmail.com>
Date:   Thu Apr 4 21:35:22 2024 +0530

    Merge branch 'main' into float32

commit 5764ef8
Author: Aravind <aravindp1510@gmail.com>
Date:   Mon Apr 1 17:40:34 2024 +0530

    Support FLOAT32 type in v1 templates of Spanner.

    Squashed commit of the following:

    commit a678a75
    Merge: f9fe874 c9f1c66
    Author: Aravind Pedapudi <aravindp1510@gmail.com>
    Date:   Mon Apr 1 16:08:20 2024 +0530

        Merge branch 'main' into float32

    commit f9fe874
    Merge: e28335c 7449ae6
    Author: Aravind Pedapudi <aravindp1510@gmail.com>
    Date:   Thu Mar 28 10:50:24 2024 +0530

        Merge branch 'main' into float32

    commit e28335c
    Author: Aravind <aravindp1510@gmail.com>
    Date:   Wed Mar 27 16:33:56 2024 +0530

        Fix integration test failures for TextImportPipelineIT

    commit 8480654
    Merge: c6364b7 afd1dc2
    Author: Aravind <aravindp1510@gmail.com>
    Date:   Wed Mar 27 16:25:57 2024 +0530

        Merge branch 'float32' of github.com:arawind/DataflowTemplates into float32

    commit c6364b7
    Author: Aravind <aravindp1510@gmail.com>
    Date:   Wed Mar 27 16:22:27 2024 +0530

        Add avro integration tests for FLOAT32 type in Spanner.

        This fixes the ExportPipelineIT and adds support for the
        ImportPipelineIT.

    commit afd1dc2
    Merge: eca6acf 4536653
    Author: Aravind Pedapudi <aravindp1510@gmail.com>
    Date:   Wed Mar 27 11:37:24 2024 +0530

        Merge branch 'main' into float32

    commit eca6acf
    Author: Aravind <aravindp1510@gmail.com>
    Date:   Fri Mar 22 17:12:35 2024 +0530

        Address review comments

        Adds new tests in ExportPipelineIT and also removes the INT32 -> FLOAT32 parsing as we don't see any use for it.

    commit c1cd281
    Author: Aravind <aravindp1510@gmail.com>
    Date:   Thu Mar 21 18:15:05 2024 +0530

        Fix Beam to handle float32 arrays and pg schema.

        This was missed in the earlier commits

    commit 5e936f4
    Author: Aravind <aravindp1510@gmail.com>
    Date:   Thu Mar 21 13:32:01 2024 +0530

        Address review comments

    commit f4ab908
    Merge: a6aba30 1df7e0a
    Author: Aravind Pedapudi <aravindp1510@gmail.com>
    Date:   Thu Mar 21 12:56:09 2024 +0530

        Merge branch 'GoogleCloudPlatform:main' into float32

    commit a6aba30
    Merge: 66c488c f44f7ce
    Author: Aravind Pedapudi <aravindp1510@gmail.com>
    Date:   Wed Mar 20 16:21:11 2024 +0530

        Merge branch 'main' into float32

    commit 66c488c
    Author: Aravind <aravindp1510@gmail.com>
    Date:   Wed Mar 20 15:49:31 2024 +0530

        Fix gax dependency failures in spanner integration tests.

        We were seeing this error in the spanner integration tests: `class com.google.cloud.spanner.v1.stub.SpannerStubSettings overrides final method com.google.api.gax.rpc.StubSettings.getEndpoint()Ljava/lang/String;`, which were triggered by the google-cloud-spanner BOM update to 6.61.
        We're fixing these errors by setting the gax version to the one used by Cloud Spanner client libs. This should be removed once Beam is updated to the latest version of gax (which may happen when Beam's dependency on Spanner is updated).

    commit 90c1fbc
    Author: Aravind <aravindp1510@gmail.com>
    Date:   Tue Mar 19 19:17:03 2024 +0530

        Support FLOAT32 type in v1 spanner templates

    commit 51f75f0
    Author: Aravind <aravindp1510@gmail.com>
    Date:   Tue Mar 19 19:10:06 2024 +0530

        Modify the local copy of Beam to support FLOAT32 type.

    commit f85fd00
    Author: Aravind <aravindp1510@gmail.com>
    Date:   Tue Mar 19 18:53:17 2024 +0530

        Update the version of google-cloud-spanner-bom to 6.61.0

Upgrade Beam version to 2.55.1

Specify venv

single commit off of master

No-op comment change to kick copybara

Revert "No-op comment change to kick copybara"

This reverts commit 928dc6b.

Different no-op to kick copybara and avoid conflicts

PR GoogleCloudPlatform#1376: Support FLOAT32 type in v1 templates of Spanner

Please approve this CL. It will be submitted automatically, and its GitHub pull request will be marked as merged.

Imported from GitHub PR GoogleCloudPlatform#1376

GoogleSQL:
* [Export](https://console.cloud.google.com/dataflow/jobs/us-central1/2024-03-21_05_01_22-9618753751624897563;graphView=0?project=span-cloud-testing&pageState=(%22dfTime%22:(%22l%22:%22dfJobMaxTime%22)))
* [Import](https://console.cloud.google.com/dataflow/jobs/us-central1/2024-03-21_05_38_00-8680174928377892705;graphView=0?project=span-cloud-testing&pageState=(%22dfTime%22:(%22l%22:%22dfJobMaxTime%22)))

PG:
* [Export](https://console.cloud.google.com/dataflow/jobs/us-central1/2024-03-21_05_47_07-2771163877050158940;graphView=0?project=span-cloud-testing&pageState=(%22dfTime%22:(%22l%22:%22dfJobMaxTime%22)))
* [Import](https://console.cloud.google.com/dataflow/jobs/us-central1/2024-03-21_05_58_11-1643174307354839989;graphView=0?project=span-cloud-testing&pageState=(%22dfTime%22:(%22l%22:%22dfJobMaxTime%22)))

GoogleSQL:
* [Export](https://console.cloud.google.com/dataflow/jobs/us-central1/2024-03-22_00_17_56-5509502875882896332?e=13802955&mods=monitoring_api_prod&project=span-cloud-testing)
* [Import](https://console.cloud.google.com/dataflow/jobs/us-central1/2024-03-22_02_50_39-14326646282971458157?e=13802955&mods=monitoring_api_prod&project=span-cloud-testing)

PG:
* [Export](https://console.cloud.google.com/dataflow/jobs/us-central1/2024-03-22_03_17_13-5127588554893435640;graphView=0?project=span-cloud-testing&e=13802955&mods=monitoring_api_prod&pageState=(%22dfTime%22:(%22l%22:%22dfJobMaxTime%22)))
* [Import](https://console.cloud.google.com/dataflow/jobs/us-central1/2024-03-22_03_09_55-9477941764979866789?e=13802955&mods=monitoring_api_prod&project=span-cloud-testing)

Copybara import of the project:

  - 357481bb0fdfba9c91fdde1c24ae4bbcaf5d2bf4 Support FLOAT32 type in v1 templates of Spanner. by Aravind <aravindp1510@gmail.com>

COPYBARA_INTEGRATE_REVIEW=GoogleCloudPlatform#1376 from arawind:float32 357481bb0fdfba9c91fdde1c24ae4bbcaf5d2bf4
PiperOrigin-RevId: 622232578

String change to match external

PiperOrigin-RevId: 622247573

Add schemaMapperInterface and implementations

Add namespace to params

spotless

Add user-agent string to Elasticsearch templates

Rename templateName to userAgent

Fix style

Capitalize header name

Add unit tests

Fix style

Bugfix for UI issue removing flex templates from drop down menu

Use beam version defined in the pom.xml to make sure we stay on the most current version. Also add a comment regarding the hashed file location for context.

Implement enum based experiment value provider

disable YamlTemplateIT's until GoogleCloudPlatform#1405 is merged

Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>

Add smoke tests for the no UDF case for Xlang templates, abstract conversion functions, fix bug with flexContainerName.

A small simplification in Bulk Reader tests.

Allow manual triggering of PR workflow

Add python version to setup-env actions

Add parentName and parentTriggerValues attributes

Test that new attributes are present

Remove redundant line
copybara-service bot pushed a commit that referenced this pull request Apr 19, 2024
Please approve this CL. It will be submitted automatically, and its GitHub pull request will be marked as merged.

Imported from GitHub PR #1413

removed deprecated reverse replication templates

Copybara import of the project:

  - 2c59830 removed deprecated reverse replicaiton templates by Akshara Uke <aksharau@google.com>

COPYBARA_INTEGRATE_REVIEW=#1376 from arawind:float32 357481bb0fdfba9c91fdde1c24ae4bbcaf5d2bf4
PiperOrigin-RevId: 626357039
fozzie15 added a commit that referenced this pull request Apr 19, 2024
Add Python UDF support for Elastic Search Templates.

Add parentName and parentTriggerValues attributes

Test that new attributes are present

Remove redundant line

fixed escape characters and timer type

YamlTemplate speed improvements

Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>

rebase

Add python version to setup-env actions

Add parentName and parentTriggerValues attributes

Test that new attributes are present

Remove redundant line

fixed escape characters and timer type

YamlTemplate speed improvements

Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>

PR #1413: removed deprecated reverse replication templates

Please approve this CL. It will be submitted automatically, and its GitHub pull request will be marked as merged.

Imported from GitHub PR #1413

removed deprecated reverse replication templates

Copybara import of the project:

  - 2c59830 removed deprecated reverse replicaiton templates by Akshara Uke <aksharau@google.com>

COPYBARA_INTEGRATE_REVIEW=#1376 from arawind:float32 357481bb0fdfba9c91fdde1c24ae4bbcaf5d2bf4
PiperOrigin-RevId: 626357039
@liferoad
Copy link
Copy Markdown
Contributor

Is this PR still needed?

@aksharauke aksharauke closed this Apr 23, 2024
@aksharauke
Copy link
Copy Markdown
Contributor Author

merged hence closing

@aksharauke aksharauke deleted the rr branch April 25, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Google LGTM Approval of a pull request to be merged into the repository size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants