core(image-elements): cache naturalSize results#9818
Merged
Conversation
Collaborator
|
how much faster tho |
Member
Author
25s to 1s on selfridges |
patrickhulce
approved these changes
Oct 11, 2019
Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
Contributor
that doesn't seem possible, fwiw, or the protocol timeout is broken :) lighthouse/lighthouse-core/gather/gatherers/image-elements.js Lines 141 to 142 in 6d56a70 I get like 8s -> 250ms, which is still 👍 |
Contributor
oh, I take it back. It's because they all share a network record so we just repeatedly fetch the same images 2000 times? Dear lord, yeah, good find. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This url is quite slow to run: https://www.selfridges.com/US/en/cat/womens/newin/
On the CLI, the ImageElements gatherer can take 25-30 seconds to run.
Turns out that gatherer finds ~2000 images, however 99% of them are country flag DOM elements with a css background using the exact same sprite image.
While we have added that smart only-do-the-50-most-important-network-images check... we don't handle the case of multiple background images pointing to the same asset that's within the top 50.
But now we do. :)