core(seo): support portuguese in link-text audit#9446
Merged
patrickhulce merged 3 commits intoGoogleChrome:masterfrom Jul 30, 2019
letanure:master
Merged
core(seo): support portuguese in link-text audit#9446patrickhulce merged 3 commits intoGoogleChrome:masterfrom letanure:master
patrickhulce merged 3 commits intoGoogleChrome:masterfrom
letanure:master
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Contributor
Author
|
I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
patrickhulce
approved these changes
Jul 24, 2019
Collaborator
patrickhulce
left a comment
There was a problem hiding this comment.
thanks very much @letanure!! 🇵🇹
I think at this point we've rejected a formal process here, so the Google Translations are good enough for me :) 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Portuguese translations for the Links Do Not Have Descriptive Text
Note that in Portuguese there is this symbol: ´. People forget to write it so we may take into account these errors, let me know your opinion.
feature, since adding new words to the test
Portuguese is one of the top 10 languages used on the internet ref1
translated words for non-portuguese speakers
Related Issues/PRs
#7547 #5322