Add script to compile renderer against TOT devtools frontend#2099
Add script to compile renderer against TOT devtools frontend#2099
Conversation
93052a7 to
6b39500
Compare
096599d to
0ee61fa
Compare
| cd "$protocol_path" && git reset --hard && git fetch origin master && git checkout --force origin/master | ||
|
|
||
|
|
||
| cd "$lhroot_path" || exit 1 |
There was a problem hiding this comment.
does this fail sometimes?
There was a problem hiding this comment.
no but https://www.shellcheck.net/ recommends it so i do it. :)
package.json
Outdated
| "unit": "bash lighthouse-core/scripts/run-mocha.sh --default", | ||
| "closure": "cd lighthouse-core && node closure/closure-type-checking.js", | ||
| "devtools": "bash lighthouse-core/scripts/roll-to-devtools.sh", | ||
| "compdevtools": "bash lighthouse-core/scripts/compile-against-devtools.sh", |
There was a problem hiding this comment.
I know you love 🖐 but I didn't know what this meant haha, can we do compile-devtools? it's only 4 more characters :)
There was a problem hiding this comment.
sure sure.
i found and installed https://github.com/mklabs/yarn-completions which does completions for our scripts on yarn run so i'm happy now. :)
0ee61fa to
f68c782
Compare
|
@brendankenny merge when ready |
brendankenny
left a comment
There was a problem hiding this comment.
cool!
Though doesn't compile with no errors here. It doesn't know what Util is in reportRenderer. Expected?
- should we add this to CONTIBUTING?
- should we add this to testing? That would be ideal, as it would prevent a lot of work on your part to fix up after every report change, and it would likely help report render changes be less crazy, but we also have no workflow for making changes over there if we need them to make a change over there.
After a perusal it appears this is non-destructive on my Lighthouse repo, so I can run multiple times/run in an in-progress change. Correct?
sure.
the plan is to flip it on once we get it passing on master. (last i checked master wasn't yet passing)
totally. run as much as you like. doesn't affect your LH files. |
yeah, that's what I just ran into. LGTM! |
|
added a note to readme: |
fixes #2050
output: