tests(dbw): update expectations for unload handler removal#15765
Merged
tests(dbw): update expectations for unload handler removal#15765
Conversation
connorjclark
approved these changes
Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like Chrome has officially pulled the plug on unload handlers. IMO Lighthouse still delivers the correct advice which is flagging the console error for trying to use an unload listener, but not flagging anything in
no-unload-listenersaudit.Attempting to use an unload listener creates a permission request now that blocks bfcache, but that is marked pending browser support so could change in a future Chrome patch.
We should remove the
no-unload-listenersaudit for 12.0, so #15752 is probably unnecessary.