Skip to content

core(image-elements): use execution context isolation#14005

Merged
connorjclark merged 6 commits into
masterfrom
img-el-isolate
May 19, 2022
Merged

core(image-elements): use execution context isolation#14005
connorjclark merged 6 commits into
masterfrom
img-el-isolate

Conversation

@connorjclark

Copy link
Copy Markdown
Collaborator

mentioned in #14003

@connorjclark connorjclark requested a review from alexnj May 14, 2022 00:21
@connorjclark connorjclark requested a review from a team as a code owner May 14, 2022 00:21
@connorjclark connorjclark requested review from brendankenny and removed request for a team May 14, 2022 00:21
@adamraine

adamraine commented May 14, 2022

Copy link
Copy Markdown
Contributor

Hmm looks like we can't use isolation here

EDIT: Or maybe the LH ids just changed

@connorjclark

Copy link
Copy Markdown
Collaborator Author

Yeah, the ids in the smoke test need to be updated.

@alexnj alexnj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants