Skip to content

docs: in-progress changelog for v8.0#12596

Merged
paulirish merged 5 commits into
bump_8.0.0from
v8changelog
Jun 2, 2021
Merged

docs: in-progress changelog for v8.0#12596
paulirish merged 5 commits into
bump_8.0.0from
v8changelog

Conversation

@brendankenny

@brendankenny brendankenny commented Jun 1, 2021

Copy link
Copy Markdown
Contributor

see #11866

to merge into #12593

@brendankenny brendankenny requested a review from a team as a code owner June 1, 2021 22:44
@brendankenny brendankenny requested review from adamraine and removed request for a team June 1, 2021 22:44
@google-cla google-cla Bot added the cla: yes label Jun 1, 2021
Comment thread changelog.md
- update cumulative-layout-shift ([#12554](https://github.com/GoogleChrome/lighthouse/pull/12554))
- update FCP score curve ([#12556](https://github.com/GoogleChrome/lighthouse/pull/12556))
* The report includes a new metric filter. Pick a metric to focus on the opportunities and diagnostics most relevant to improving just that metric:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth linking up to the score calc + include a screenshot of it for the perf category section?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for fun i added that in #12597

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@adamraine

Copy link
Copy Markdown
Contributor

This LGTM pending your TODO

Co-authored-by: Brendan Kenny <bckenny@gmail.com>
Co-authored-by: Patrick Hulce <patrick.hulce@gmail.com>
@google-cla

google-cla Bot commented Jun 2, 2021

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added cla: no and removed cla: yes labels Jun 2, 2021
@paulirish

Copy link
Copy Markdown
Member

@googlebot I consent

@google-cla google-cla Bot added cla: yes and removed cla: no labels Jun 2, 2021
@paulirish paulirish merged commit 548ab93 into bump_8.0.0 Jun 2, 2021
@paulirish paulirish deleted the v8changelog branch June 2, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants