Skip to content

v8.0.0#12593

Merged
connorjclark merged 7 commits into
masterfrom
bump_8.0.0
Jun 2, 2021
Merged

v8.0.0#12593
connorjclark merged 7 commits into
masterfrom
bump_8.0.0

Conversation

@connorjclark

@connorjclark connorjclark commented Jun 1, 2021

Copy link
Copy Markdown
Collaborator

we chillin' until changelog/v8 faq is written 💥 💥

@google-cla google-cla Bot added the cla: yes label Jun 1, 2021
Comment thread changelog.md

Currently, only reports generated with the Lighthouse Node CLI will connect to the Lighthouse Treemap App. We are working on adding this functionality to Lighthouse in DevTools and PageSpeed Insights.

[Demo](https://googlechrome.github.io/lighthouse/treemap/?gist=30a18304de56e7be08f10976a1b11702)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the treemap section alone may soon be bigger than any individual version's release log (except 7.5.0 itself, of course) :P

More seriously, this is going to rapidly get pushed down the changelog. Should we expand lighthouse-treemap/readme.md instead?

@connorjclark connorjclark Jun 1, 2021

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(fyi I added this link to the GH changelog post-release as an after thought. it was to the viewer. I just updated it to link to treemap directly, and added that link to the changelog file here)

All the wording here is a point-in-time commentary on the feature, and I don't see a reason to be concerned about the length of releases or sections here, so I don't think it matters.

Or do you just mean also adding the link to that other readme file?

@brendankenny brendankenny Jun 1, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the wording here is a point-in-time commentary on the feature, and I don't see a reason to be concerned about the length of releases or sections here, so I don't think it matters.

I mean it's a reference for changes, not a blog post. IMO even major changes should only have enough description to give an idea why they're significant, with an issue/PR link if someone wants to learn more. Otherwise it sabotages using the file as a cross-reference/development timeline. But that's just the classic release notes/changelog discussion...

Or do you just mean also adding the link to that other readme file?

Yes, this is what I meant in the actually constructive part of my comment. This is going to be pushed down and in a release or two (relatively) no one is ever going to see it. We should some form of this whole entry to treemap/readme.md (or wherever) so it's still in a place people will look for it.

@paulirish paulirish marked this pull request as ready for review June 2, 2021 17:21
@paulirish paulirish requested a review from a team as a code owner June 2, 2021 17:21
@paulirish paulirish requested review from patrickhulce and removed request for a team June 2, 2021 17:21

@brendankenny brendankenny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢 🚚 🚂

@patrickhulce patrickhulce left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants