Skip to content

misc(treemap): fix colors#12462

Merged
connorjclark merged 5 commits into
masterfrom
treemap-fix-colors
May 11, 2021
Merged

misc(treemap): fix colors#12462
connorjclark merged 5 commits into
masterfrom
treemap-fix-colors

Conversation

@connorjclark

@connorjclark connorjclark commented May 11, 2021

Copy link
Copy Markdown
Collaborator
  1. Changed the stableHasher function to recycle items, so that colors never run out.
  2. I had added a fake jquery duplication to debug.json, but it turns out that there were visible duplicates but they were given white because of 1). So I removed the fake duplication.
  3. Refactored ViewMode.highlight. I figured this property should be responsible for declaring what color a specific node should be.

ref #11254

@connorjclark connorjclark requested a review from a team as a code owner May 11, 2021 00:52
@connorjclark connorjclark requested review from patrickhulce and removed request for a team May 11, 2021 00:52
@google-cla google-cla Bot added the cla: yes label May 11, 2021
@connorjclark connorjclark mentioned this pull request May 11, 2021
24 tasks
Comment thread lighthouse-treemap/app/src/util.js
@connorjclark connorjclark merged commit f06807b into master May 11, 2021
@connorjclark connorjclark deleted the treemap-fix-colors branch May 11, 2021 17:57
paulirish pushed a commit that referenced this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants