core(fr): add base gatherer class#11917
Merged
Merged
Conversation
adamraine
approved these changes
Jan 6, 2021
Co-authored-by: Adam Raine <6752989+adamraine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the base Fraggle Rock gatherer class that allows transition of gatherers to implement both APIs.
Why a new class instead of the augmenting the old class? Clarity. This approach allows anyone reading a gatherer file to immediately see whether it supports the new modes or not. We'll also be able to know from a type perspective that a gatherer doesn't support the new method, forcing a one-by-one examination of each gatherer as we upgrade them for FR.
Related Issues/PRs
ref #11313
Design Doc