Skip to content

tests: add more files in lighthouse-core/tests to tsconfig#11728

Merged
devtools-bot merged 4 commits into
masterfrom
more-test-types
Dec 23, 2020
Merged

tests: add more files in lighthouse-core/tests to tsconfig#11728
devtools-bot merged 4 commits into
masterfrom
more-test-types

Conversation

@connorjclark

@connorjclark connorjclark commented Nov 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Adds type coverage for 17 test files in lighthouse-core/test/
  • Changes lighthouse-core/test/**/*.js exclude to excluding lighthouse-core/test/(audits,report,fixtures,computed)/**/*.js. Removing any of these usually results in tsc running out of memory. Some super complex type causes OOM. Would be interesting to identify the exact cause of this later.
  • Newly created test files in lighthouse-core/test/{gather,lib,scripts} will be type checked by default, unless added to this exclude list

These are the files now covered by the tsconfig (all without any changes necessary)

lighthouse-core/test/gather/driver-test.js
lighthouse-core/test/gather/driver/execution-context-test.js
lighthouse-core/test/gather/fake-driver.js
lighthouse-core/test/gather/gather-runner-test.js
lighthouse-core/test/gather/gatherers/gatherer-test.js
lighthouse-core/test/gather/mock-commands.js
lighthouse-core/test/lib/dependency-graph/simulator/tcp-connection-test.js
lighthouse-core/test/lib/file-namer-test.js
lighthouse-core/test/lib/line-number-from-jsonld-path-test.js
lighthouse-core/test/lib/tappable-rects-test.js
lighthouse-core/test/lib/third-party-web-test.js
lighthouse-core/test/network-records-to-devtools-log.js
lighthouse-core/test/results/sample-config.js
lighthouse-core/test/scripts/i18n/collect-strings-test.js
lighthouse-core/test/scripts/i18n/prune-obsolete-lhl-messages-test.js
lighthouse-core/test/scripts/lantern/constants-test.js
lighthouse-core/test/test-utils.js

@connorjclark connorjclark requested a review from a team as a code owner November 30, 2020 21:52
@connorjclark connorjclark requested review from adamraine and removed request for a team November 30, 2020 21:52
@google-cla google-cla Bot added the cla: yes label Nov 30, 2020
adamraine
adamraine approved these changes Dec 1, 2020
View reviewed changes

@adamraine adamraine left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brendankenny brendankenny mentioned this pull request Dec 15, 2020
Merged
@devtools-bot devtools-bot merged commit d584194 into master Dec 23, 2020
@devtools-bot devtools-bot deleted the more-test-types branch December 23, 2020 00:03
@brendankenny brendankenny mentioned this pull request Jan 5, 2021
Merged
paulirish pushed a commit that referenced this pull request Mar 23, 2021
@connorjclark @paulirish
tests: add more files in lighthouse-core/tests to tsconfig (#11728)
8256b86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamraine adamraine adamraine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adamraine adamraine

Labels

cla: yes waiting4committer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@connorjclark @adamraine @devtools-bot