v6.1.0 by connorjclark · Pull Request #11025 · GoogleChrome/lighthouse

connorjclark · 2020-06-25T05:49:29Z

I got to this later than I planned–just tossing this up for now and will give a first pass in the morning.

meta

generating this changelog was a real hassle and I'm not certain why.

the changelog generator collects a list of git tags by calling git log --decorate --no-color and filtering based on tag: .... but the way it does this misses the v6.0.0 for some reason, so I was given a changelong of v5.6.0...6.1.0.

it basically does this

git log --decorate --no-color | grep tag:                                                                       SIGPIPE(13) ↵  10993  22:41:50
commit 468c10bb9df7ded215b7a3c47e23f48c1af656f7 (tag: v6.0.0-beta.0)
commit 848b54397bd062f83d00ac8a87608df8011cf8f1 (tag: v5.6.0)
commit 4e15a56171be0c622186b3ce58cf1fbce000e9e5 (tag: v5.5.0)
commit 364ca5919296235dfcc00f20f8ccca9ec33807c0 (tag: v5.4.0)
commit f170bed81b1e102ab3655529dd70e07dd28944b3 (tag: v5.3.0)
commit ba1e1591dd83fe411f058df31a994df76796f646 (tag: v5.2.0)
commit cab03b4b5afa52ccd27c8fcb1582d1ba0a0e1410 (tag: v5.1.0)
...

notice there's no v6.0.0

the v6.0.0 tag points to c61e0d662c0f1156e3d174529bcf7e29e1b26566, which if you log it with git log c61e0d6...

what teh eff, there's the tag...

the tag doesn't show up (different commit too..) if you do just git log --decorate (Thus why it didn't get picked up by changelog generator)

@brendankenny @paulirish wat did ya'll do? 😢

once I figured out the issue I just manually push v6.0.0 to the tags in node_modules/git-semver-tags/index.js and commented out some lines in prepare-commit.sh.

brendankenny · 2020-06-25T14:12:24Z

@brendankenny @paulirish wat did ya'll do? 😢

$git show v6.0.0\ntag v6.0.0\nTagger: Paul Irish <commits@paul.irish>$

/me ducks
😁

(I actually have no idea what happened)

patrickhulce · 2020-06-25T14:51:27Z

+Umar Hansa <umar.hansa@gmail.com>
+
+## Notable Changes
+~~ TODO: Move notable changes here ~~


not sure we have major ones, 6.2 will be juicy with 'em though :)

I added two things here.

patrickhulce · 2020-06-25T14:53:25Z

+Loftie Ellis <lpellis@gmail.com>
+Marvin Frachet <marvin.frachet@gmail.com>
+Matt Hobbs <matthew.hobbs@digital.cabinet-office.gov.uk>
+Peter Marshall <p.s.marshall0@gmail.com>
+Umar Hansa <umar.hansa@gmail.com>


we should really try to map these back to github login, I guess we could replace it with a github API lookup on the commit itself?

I can look into that

for this release just manual?

Suggested change

Loftie Ellis <lpellis@gmail.com>

Marvin Frachet <marvin.frachet@gmail.com>

Matt Hobbs <matthew.hobbs@digital.cabinet-office.gov.uk>

Peter Marshall <p.s.marshall0@gmail.com>

Umar Hansa <umar.hansa@gmail.com>

Loftie Ellis @lpellis

Marvin Frachet @mfrachet

Matt Hobbs @Nooshu

Peter Marshall @psmarshall

yes please and ty so much for doing this bit for me :)

ref #9857

connorjclark · 2020-06-25T17:16:12Z

+* axe-core: upgrade to 3.5.5 ([#10986](https://github.com/GoogleChrome/lighthouse/pull/10986))
+* upgrade chrome-launcher@0.13.3 ([#10911](https://github.com/GoogleChrome/lighthouse/pull/10911))
+* snyk: update snyk snapshot ([#10840](https://github.com/GoogleChrome/lighthouse/pull/10840), [#10940](https://github.com/GoogleChrome/lighthouse/pull/10940), [#10980](https://github.com/GoogleChrome/lighthouse/pull/10980), [#11010](https://github.com/GoogleChrome/lighthouse/pull/11010))
+* remove bundlesize ([#10999](https://github.com/GoogleChrome/lighthouse/pull/10999))


should these two be in Tests?

connorjclark · 2020-06-25T17:16:25Z


 ~~ TODO: https://chromiumdash.appspot.com/schedule ~~
-We expect this release to ship in the DevTools of Chrome XX.
+We expect this release to ship in the DevTools of [Chrome XX](https://chromiumdash.appspot.com/schedule).


any chance there's a permalink to a version? I couldn't find one easily. It's a shame the link is mostly useless after 18 weeks

theres this https://calendar.google.com/calendar/embed?src=google.com_c1f795f7cg83sv2qu15c4v1kfk%40group.calendar.google.com

not very automatable

connorjclark · 2020-06-25T17:16:34Z

+
+## I18n
+
+* adjust LCP element description ([#11018](https://github.com/GoogleChrome/lighthouse/pull/11018))


cc @exterkamp fyi I think we want to keep i18n: to just things that affect the i18n system, not that touch any string

Makes sense. Been awhile since I've used these tags 😟

I think that was actually my bad. I think it was core(i18n): and I was like "don't we have an i18n separate scope? and changed it before merge".

I kinda stand by the fact that this was an adjustment raised by i18n clarity purposes, but agreed generally strings shouldn't be i18n scope. Maybe core(lcp): adjust element description would've been best?

report feels weird since it has nothing to do with HTML report, it applies to all LHR uses

report feels weird since it has nothing to do with HTML report, it applies to all LHR uses

yeah, it feels a little weird but I usually put these in core

brendankenny · 2020-06-25T17:30:45Z


 ~~ TODO: https://chromiumdash.appspot.com/schedule ~~
-We expect this release to ship in the DevTools of Chrome XX.
+We expect this release to ship in the DevTools of [Chrome XX](https://chromiumdash.appspot.com/schedule).


any chance there's a permalink to a version? I couldn't find one easily. It's a shame the link is mostly useless after 18 weeks

Co-authored-by: Brendan Kenny <bckenny@gmail.com>

brendankenny · 2020-06-25T19:49:02Z

+Loftie Ellis @lpellis
+Marvin Frachet @mfrachet 
+Matt Hobbs @Nooshu 
+Peter Marshall @psmarshall 


formatting on these doesn't look so great

brendankenny · 2020-06-25T19:50:02Z

+* If a page has publicly-accessible JavaScript source maps, Lighthouse will collect them to enhance the `unused-javascript` audit. In future versions of Lighthouse, source maps will be used for entirely new audits [#10990](https://github.com/GoogleChrome/lighthouse/pull/10990)
+* The report now uses `KiB` instead of `KB`. This is simply a label change; the value was and still is equal to `1024 bytes` [#10870](https://github.com/GoogleChrome/lighthouse/pull/10870)
+
+<img src="https://i.imgur.com/1gSdPw5.png" alt="Unused JavaScript with source maps" width="800px">


should be with the second bullet point?

I thought it was a nice showcase of both at the same time :)

it shows both things tho

I thought it was a nice showcase of both at the same time :)

it shows both things tho

oh, haha, fair enough

brendankenny

otherwise LGTM2!

Co-authored-by: Brendan Kenny <bckenny@gmail.com>

connorjclark added 2 commits June 24, 2020 22:46

v6.1.0

f78f7a7

edit

0861ade

connorjclark requested a review from a team as a code owner June 25, 2020 05:49

connorjclark requested review from patrickhulce and removed request for a team June 25, 2020 05:49

googlebot added the cla: yes label Jun 25, 2020

devtools-bot assigned patrickhulce Jun 25, 2020

devtools-bot added the waiting4reviewer label Jun 25, 2020

connorjclark commented Jun 25, 2020

View reviewed changes

Comment thread docs/recipes/custom-gatherer-puppeteer/package.json

patrickhulce reviewed Jun 25, 2020

View reviewed changes

patrickhulce added waiting4committer and removed waiting4reviewer labels Jun 25, 2020

patrickhulce mentioned this pull request Jun 25, 2020

core(unused-javascript): increase threshold to 20KiB #10906

Merged

first pass

85b5a0b

vercel Bot deployed to Preview June 25, 2020 17:15 View deployment

connorjclark commented Jun 25, 2020

View reviewed changes

Comment thread changelog.md

pr

054d39e

vercel Bot deployed to Preview June 25, 2020 18:23 View deployment

brendankenny reviewed Jun 25, 2020

View reviewed changes

Update changelog.md

e3b5dbc

Co-authored-by: Brendan Kenny <bckenny@gmail.com>

vercel Bot deployed to Preview June 25, 2020 18:41 View deployment

Update changelog.md

635187c

Co-authored-by: Brendan Kenny <bckenny@gmail.com>

vercel Bot deployed to Preview June 25, 2020 18:42 View deployment

Apply suggestions from code review

750494d

Co-authored-by: Brendan Kenny <bckenny@gmail.com>

vercel Bot deployed to Preview June 25, 2020 18:44 View deployment

update

b93429d

vercel Bot deployed to Preview June 25, 2020 18:51 View deployment

bigger

886a867

vercel Bot deployed to Preview June 25, 2020 18:52 View deployment

pr

278017b

vercel Bot deployed to Preview June 25, 2020 18:53 View deployment

connorjclark mentioned this pull request Jun 25, 2020

☔ release script improvements #9857

Closed

14 tasks

patrickhulce approved these changes Jun 25, 2020

View reviewed changes

brendankenny reviewed Jun 25, 2020

View reviewed changes

brendankenny approved these changes Jun 25, 2020

View reviewed changes

Comment thread changelog.md Outdated

Comment thread changelog.md Outdated

k

f7c1355

vercel Bot deployed to Preview June 25, 2020 19:53 View deployment

Apply suggestions from code review

ed46338

Co-authored-by: Brendan Kenny <bckenny@gmail.com>

vercel Bot deployed to Preview June 25, 2020 19:54 View deployment

brendankenny mentioned this pull request Jun 25, 2020

tests: parallelize all the tests #11009

Merged

connorjclark merged commit 4c4b628 into master Jun 25, 2020

connorjclark deleted the bump_6.1.0 branch June 25, 2020 20:27

kristoferbaxter mentioned this pull request Jun 26, 2020

PageSpeed Insights now reporting all AMP scripts as "Unused Javascript" ampproject/amphtml#28638

Closed

makunde pushed a commit to makunde/lighthouse that referenced this pull request Jul 6, 2020

v6.1.0 (GoogleChrome#11025)

e38133e

Co-authored-by: Brendan Kenny <bckenny@gmail.com>

makunde pushed a commit to makunde/lighthouse that referenced this pull request Aug 28, 2020

v6.1.0 (GoogleChrome#11025)

1ff6b6d

Co-authored-by: Brendan Kenny <bckenny@gmail.com>


		## I18n

		* adjust LCP element description ([#11018](https://github.com/GoogleChrome/lighthouse/pull/11018))

Conversation

connorjclark commented Jun 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

meta

Uh oh!

Uh oh!

brendankenny commented Jun 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

connorjclark Jun 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brendankenny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

connorjclark commented Jun 25, 2020 •

edited

Loading

brendankenny commented Jun 25, 2020 •

edited

Loading

connorjclark Jun 25, 2020 •

edited

Loading