Update package-lock.json#1452
Merged
Merged
Conversation
amieiro
added a commit
to amieiro/GlotPress
that referenced
this pull request
Jun 15, 2022
amieiro
added a commit
to amieiro/GlotPress
that referenced
this pull request
Jun 15, 2022
amieiro
added a commit
to amieiro/GlotPress
that referenced
this pull request
Jun 15, 2022
amieiro
added a commit
to amieiro/GlotPress
that referenced
this pull request
Jun 20, 2022
ocean90
approved these changes
Jul 13, 2022
amieiro
added a commit
that referenced
this pull request
Sep 15, 2022
* PoC: Add the changes requested status * Add a new hided button for the new status * Add a new listener for the new status button * Add the new status (changes_requested) in the bulk post and bulk approve * Update a failing test * Update the package-lock.json with "npm update" * Update the package-lock.json with "npm update" * Update the package-lock.json from #1452 * Add the minimized JavaScript * Add some checks to view the new status only with the WPORG_TRANSLATE_BLOGID constant available To view the new status in the frontend, you need to add the WPORG_TRANSLATE_BLOGID constant in the wp-config.php file with the value of the get_current_blog_id() function. E.g.: define( 'WPORG_TRANSLATE_BLOGID', 1 ); * Update the check to see if the gp-translation-helpers plugin is installed Check if the 'gp_translation_helper_installed' filter returns true -> plugin installed. * Update the filter name from gp_translation_helper_installed to gp_enable_changes_requested_status * Some updates to show the changes_requested strings as rejected if the gp_enable_changes_requested_status is not enabled * Set the changes_requested as untranslated if the gp_enable_changes_requested_status is not enabled * Update the margin for the action buttons * Update the hook for the changes_requested buttons * Update texts: changes_requested to changesrequested and request_changes to requestchanges * Resolve a bug in the filter form * Update the changesrequested showed value, with the uppercase * Bugfix. Update the value for the changesrequested value if this status is not enabled * Rearrange some conditions in an if statement * Add some comments in an if and remove some parenthesis * Add some comments in an if and remove some parenthesis * Add a stub for set_status_changesrequested, avoiding breaking the plugin when the gp-translation-helpers plugin is not installed. Props @akirk #1451 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
package-lock.jsonto fix npm ci error