Skip to content

Bump reqwest to 0.13.1#2328

Merged
Byron merged 2 commits intoGitoxideLabs:mainfrom
NobodyXu:patch-1
Jan 2, 2026
Merged

Bump reqwest to 0.13.1#2328
Byron merged 2 commits intoGitoxideLabs:mainfrom
NobodyXu:patch-1

Conversation

@NobodyXu
Copy link
Contributor

@NobodyXu NobodyXu commented Jan 2, 2026

No description provided.

@Byron
Copy link
Member

Byron commented Jan 2, 2026

Thanks!

It looks like Cargo.lock wasn't updated. But besides that, there should be no reason not to merge this.
I just wonder if this might be a breaking change, thinking it probably isn't as reqwest isn't exposed.

@NobodyXu
Copy link
Contributor Author

NobodyXu commented Jan 2, 2026

Thanks updated Cargo.lock, but it fails in pure-rust dependencies checking, the regex is so complex that I didn't understand it😅

https://github.com/GitoxideLabs/gitoxide/actions/runs/20654302166/job/59304263816?pr=2328#step:10:1

@NobodyXu
Copy link
Contributor Author

NobodyXu commented Jan 2, 2026

Ok I got it, basically that regex forbidden all -sys except for libz-rs-sys and linux-raw-sys

it failed because of new aws-lc-sys that is pulled in, which replaces ring.

I think this is fine as ring also has a bunch of pre-generated assemblies/c that requires a compiler, cc @Byron should I update CI to whitelist aws-rc-sys?

@NobodyXu
Copy link
Contributor Author

NobodyXu commented Jan 2, 2026

Pushed a new change to whitelist aws-rc-sys for pure-rust-build

I just wonder if this might be a breaking change, thinking it probably isn't as reqwest isn't exposed.

I agree, it's probably fine to have a compatible release, I'd appreciate that

@Byron
Copy link
Member

Byron commented Jan 2, 2026

It seems to build, which really does mean that aws-lc-sys doesn't invoke the cc compiler. Great!
Should be ready to merge.

@Byron Byron mentioned this pull request Jan 2, 2026
@Byron Byron merged commit 5de660e into GitoxideLabs:main Jan 2, 2026
28 checks passed
@NobodyXu NobodyXu deleted the patch-1 branch January 2, 2026 09:21
@NobodyXu
Copy link
Contributor Author

NobodyXu commented Jan 2, 2026

Thanks!

what is the estimated release date for next release?

@Byron Byron mentioned this pull request Jan 2, 2026
@Byron
Copy link
Member

Byron commented Jan 2, 2026

I just published gix-transport as patch release. A great way to not have to wait till the 22nd :D, and also to see if I was wrong about my "it's not breaking" assessment ;).

@NobodyXu
Copy link
Contributor Author

NobodyXu commented Jan 2, 2026

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants