Make test-fixtures-windows required for PR auto-merge#1793
Merged
Byron merged 1 commit intoGitoxideLabs:mainfrom Jan 23, 2025
Merged
Make test-fixtures-windows required for PR auto-merge#1793Byron merged 1 commit intoGitoxideLabs:mainfrom
test-fixtures-windows required for PR auto-merge#1793Byron merged 1 commit intoGitoxideLabs:mainfrom
Conversation
Member
|
Alright, thank you, let's try it. |
Member
Author
|
I think the merge commit may be okay, but that the situation might be less confusing with a rebase. Edit: I've done the rebase. |
Since GitoxideLabs#1663, the `test-fixtures-windows` CI job checks actual failures against a list of specific tests that are known to fail on Windows when `GIX_TEST_IGNORE_ARCHIVES=1`. It is therefore capable of providing useful information about new failures, or newly passing tests that should be removed from the list, if the job ever does fail. The job also seems not to fail. This is to say that while GitoxideLabs#1358 is not fixed, the `test-fixtures-windows` job has a very low rate of failure and, if it does fail, something new and interesting would be happening such that we would want to know about it and probably not immediately merge a PR that caused it without checking how and why that happened. This adds `test-fixtures-windows` to the list of jobs that are dependencies of a required check for branch protection based PR auto-merge.
8275c27 to
e97c4f1
Compare
EliahKagan
added a commit
to EliahKagan/gitoxide
that referenced
this pull request
Mar 2, 2025
This removes a comment that is obsolete as of GitoxideLabs#1793.
EliahKagan
added a commit
to EliahKagan/gitoxide
that referenced
this pull request
Mar 11, 2025
This removes a comment that is obsolete as of GitoxideLabs#1793.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1663, the
test-fixtures-windowsCI job checks actual failures against a list of specific tests that are known to fail on Windows whenGIX_TEST_IGNORE_ARCHIVES=1. It is therefore capable of providing useful information about new failures, or newly passing tests that should be removed from the list, if the job ever does fail.The job also seems not to fail. This is to say that while #1358 is not fixed, the
test-fixtures-windowsjob has a very low rate of failure and, if it does fail, something new and interesting would be happening such that we would want to know about it and probably not immediately merge a PR that caused it without checking how and why that happened.This PR adds
test-fixtures-windowsto the list of jobs that are dependencies of a required check for branch protection based PR auto-merge.I know of two possible reasons not to do this now, which should be considered:
Overall it seems to me that it makes sense to do this (as argued above), but I did want to acknowledge those two counterpoints.