Reenable git-daemon journey tests on CI by disabling artifact caching#1725
Merged
Byron merged 2 commits intoGitoxideLabs:mainfrom Dec 17, 2024
Merged
Reenable git-daemon journey tests on CI by disabling artifact caching#1725Byron merged 2 commits intoGitoxideLabs:mainfrom
Byron merged 2 commits intoGitoxideLabs:mainfrom
Conversation
6 tasks
Member
|
That's wonderful, thanks so much for your help! Who would have thought…! My own tests weren't conclusive despite realising that the I am happy for the fix, and hope I won't have to look at this again anytime soon 😄. |
EliahKagan
added a commit
to EliahKagan/gitoxide
that referenced
this pull request
Dec 18, 2024
This reverts commit bf2abdb, the supporting change in GitoxideLabs#1725 that refrained from caching build artifacts from the `test-journey` job, since that no longer needs to be avoided now that `git-daemon` journey tests aren't run on CI. In 9566488 (GitoxideLabs#1634), journey tests that use `git-daemon` were disabled on CI. GitoxideLabs#1725 tried reenabling them (65788e8) and fixing them by no longer caching build artifacts with the `rust-cache` action in the `test-journey` job (bf2abdb). This worked at the time, but the exact reason it worked or how reliable it would be were unknown. It stopped working shortly thereafter in 25b8480 (GitoxideLabs#1726), and those journey tests were re-disabled on CI in d1d3f7c, which reverted 65788e8. However, bf2abdb was not reverted at that time. (The change in d1d3f7c from GitoxideLabs#1726, taken together with this commit, effectively constitute a revert of PR GitoxideLabs#1725.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running journey tests that use
git-daemonbroke in thetest-journeyCI job since #1634 for unknown reasons, and they were disabled in 9566488, as discussed in #1634 (review).This reenables those journey tests on CI, and fixes them by disabling the
rust-cachestep that caches compiled artifacts. It's rather odd that this works, but it very much does seem to.See #1634 (comment) for full details on this in a broader context, as well as other things I've tried and why none of the other things I've tried are ready to go yet.
I view this as a workaround rather than full-blown fix, but it seems to me that it's worth doing as a way to let those tests run on CI in a way that doesn't break anything else. With caching turned off, the
test-journeyjob takes up to about 6:30 to finish; it seems to me that this may be acceptable even if not ideal, given the significantly greater running time of some of the other jobs.This is, of course, only turning off artifact caching for the
test-journeyjob, not for any other jobs.