Skip to content

Failing Unit Test for Issue #1844#1845

Closed
WalkerCodeRanger wants to merge 3 commits into
GitTools:mainfrom
WalkerCodeRanger:issue-1844-out-of-order-prerelease-versions
Closed

Failing Unit Test for Issue #1844#1845
WalkerCodeRanger wants to merge 3 commits into
GitTools:mainfrom
WalkerCodeRanger:issue-1844-out-of-order-prerelease-versions

Conversation

@WalkerCodeRanger

@WalkerCodeRanger WalkerCodeRanger commented Oct 8, 2019

Copy link
Copy Markdown

Failing Unit Test for Issue #1844. Tests that the version is bumped after a prerelease tag when not doing so would put them out of order

…fter a prerelease tag when not doing so would put them out of order
@asbjornu

asbjornu commented Oct 8, 2019

Copy link
Copy Markdown
Member

Thanks, @WalkerCodeRanger. Just for fun, what happens if you change VersioningMode to Mainline?

@WalkerCodeRanger

Copy link
Copy Markdown
Author

If you change VersioningMode to Mainline without changing anything else, you get:

System.NotSupportedException : Mainline development mode doesn't yet support pre-release tags on master

@asbjornu

asbjornu commented Oct 8, 2019

Copy link
Copy Markdown
Member

Ah, right.

@asbjornu

asbjornu commented Jan 3, 2020

Copy link
Copy Markdown
Member

Will the fix implemented in #2003 help with this problem in any way?

@asbjornu

asbjornu commented Jan 3, 2020

Copy link
Copy Markdown
Member

Alas, #2003 was just merged and an update of this branch did not help. 😞

@stale

stale Bot commented Jun 30, 2020

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Jun 30, 2020
@asbjornu asbjornu added bug and removed stale labels Jun 30, 2020
Base automatically changed from master to main January 31, 2021 12:46
@arturcic arturcic force-pushed the main branch 4 times, most recently from 9801764 to b7a7608 Compare March 4, 2023 13:33
@arturcic

Copy link
Copy Markdown
Member

Closed in favor of #3445

@arturcic arturcic closed this Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants